Request 924666 (revoked)

Overview

Request 924666 revoked

- Unset SUSE_IGNORED_RPATHS to avoid a build failure caused by one
of the binutils patches (boo#1191473).

Created by cgiboudeaux over 2 years ago
In state revoked

Submit AppCSXCAD

Comments for request 924666 4

Atri Bhattacharya (badshah400) - over 2 years ago

target maintainer

Having read the bug report, it seems to me that setting CMAKE_SKIP_INSTALL_RPATH=ON during the configure stage should do it as well, and would perhaps be more preferable than unsetting SUSE_IGNORED_RPATHS. Am I wrong?

Sorry for the delayed review btw.

Christophe Giboudeaux (cgiboudeaux) - over 2 years ago

author

Enabling CMAKE_SKIP_INSTALL_RPATH would be a workaround for the issue introduced by binutils (and wrongly reassigned to the cmake maintainer)

Stefan Brüns (StefanBruens) - over 2 years ago

target maintainer

On the other hand, it has the effect of omitting any unwanted entries from RUNPATH.

IMHO both sides (CMake and binutils) need some improvement:

CMake should provide a generic way to exclude a lists of paths from RUNPATH for the install step (1)
binutils (or gcc?) should not silently break explicit requests to add a RUNPATH entry (especially if this is non-deterministic and only happens on architectures).

(1) this could be initialized with SUSE_IGNORED_RPATHS, but may be amended in specific cases with entries from e.g. /etc/ld.so.conf.d/*. This would avoid the need to fixup RPATH for system dirs (CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES), see https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#always-full-rpath