Overview
Request 942287 accepted
- add conflicts with the old krita-plugin-gmic. The old plugin no
longer works, we need to build an intree version of the plugin
now that requires a patched copy of the gmic sources.
- Update to 5.0.0
* See https://download.kde.org/stable/krita/5.0.0/
- drop 0001-Support-building-with-OpenEXR-3.patch:
included in update
- add BR to mypaint to enable the new brushes
- add BR for OpenColorIO and WebP to enable both features as well
@wolfi323 packaged the beta: https://build.opensuse.org/package/show/home:wolfi323:branches:KDE:Extra/krita
That has a diff regarding the headers and OpenColorIO, so input from him would be welcome.
opencolorIO 2 works now with krita 5, which was the reason why it was removed. and working OCIO is really nice for krita. for the headers I would have kept them in the devel package. not sure they would harm and might even be used in the gmic build.
I don't know what these gmic headers purpose is. gmic already creates a krita plugin. (https://build.opensuse.org/package/view_file/graphics/gmic/gmic.spec?expand=1)
and krita is unable to load it. Apparently, it will only recognize its own patched gmic plugin... which can't be built without the sources. (3rdparty/ext_gmic/CMakeLists.txt)
I asked in #krita about this. but nobody could tell me yet how to make it work at build time yet. you can test my package if you want.
would this also means we should have a conflict on the old plugin?
- added the conflict as the old plugin no longer works
- removed the headers as according to #krita they shouldnt be needed.
remaining question ... gmic plugin
it would require downloading a patched gmic copy from the kde server and use that for building in the krita package. thoughts from the gmic maintainer @cgiboudeaux?
I just downloaded and updated the sources to the betas (first beta1 then beta2) and quickly made them build, I haven't actually looked at it much so far (nor did I even try to install/run it).
Request History
darix created request
- add conflicts with the old krita-plugin-gmic. The old plugin no
longer works, we need to build an intree version of the plugin
now that requires a patched copy of the gmic sources.
- Update to 5.0.0
* See https://download.kde.org/stable/krita/5.0.0/
- drop 0001-Support-building-with-OpenEXR-3.patch:
included in update
- add BR to mypaint to enable the new brushes
- add BR for OpenColorIO and WebP to enable both features as well
cgiboudeaux accepted request
No need to block it longer, we already received reports from two users about krita 5.0. I'll clean before forwarding
I was about to suggest https://paste.opensuse.org/view/raw/15664369 but it would have no use. The 3rdparty plugins are only built when using krita packaging script which is not what we want.
I'll think about it later, it's not a blocker.
Well a krita user who relies on gmic might see this differently ;)
I'm not sure the
Conflicts: krita-plugin-gmicis the best idea here, as it will require manual intervention for users who have it installed, and it would even prevent installing a possibly new/updated plugin package.The conditional
BuildRequires: OpenColorIO-develshould be removed, as an unconditionalBuildRequires: pkgconfig(OpenColorIO)was added anyway.Leap has a too old OpenColorIO though, so it needs to be tested whether krita actually builds with that. IIRC from the beta's, this should not be a problem though, the feature will just not be enabled in that case.
And OpenColorIO was originally disabled because it causes a build failure on ARM though. So it would be good to test the build there too, if it fails it should rather be conditional again.
I tried, and it does build successfully on ARM and Leap.
So the unconditional variant is fine, and the conditional one (line 16ff in the spec file) should be removed.
@Vogtinator, @alarrosa, @cgiboudeaux, @christiantrippe, @luca_b, @wolfi323: review reminder