Overview
Request 945176 accepted
- Remove pointless libgraphviz6 subpackage only containing broken
and unnecessary ld.so.conf.d dropin.
- Add required Provides and Obsoletes for library package split.
- Remove unversioned symlinks for plugins, breaking shared library
policy.
- Remove duplicate python3 bindings in wrong directory (again).
- Add missing post scriptlet for webp plugin.
- Fix postun scriptlets for all plugins (be silent when graphviz
gets removed completely, report errors otherwise).
- Cleanup spec file.
- Disable Java bindings, as unused/untested, and packaging
is quite broken.
- Created by StefanBruens
- In state accepted
-
Package maintainer:
trenn
Request History
StefanBruens created request
- Remove pointless libgraphviz6 subpackage only containing broken
and unnecessary ld.so.conf.d dropin.
- Add required Provides and Obsoletes for library package split.
- Remove unversioned symlinks for plugins, breaking shared library
policy.
- Remove duplicate python3 bindings in wrong directory (again).
- Add missing post scriptlet for webp plugin.
- Fix postun scriptlets for all plugins (be silent when graphviz
gets removed completely, report errors otherwise).
- Cleanup spec file.
- Disable Java bindings, as unused/untested, and packaging
is quite broken.
trenn added michals as a reviewer
Hi Michal,
you touched this package recently.
I took over maintainership some days ago.
Would you mind having a look at this somewhat complex submit request, please.
That would really be appreciated.
michals accepted review
It looks good.
It mostly changes some technical details of library packaging and unlike the previous revision it actually builds.
There is potential for fallout in the various language bindings but I don't use those so can't comment on that.
michals approved review
It looks good.
It mostly changes some technical details of library packaging and unlike the previous revision it actually builds.
There is potential for fallout in the various language bindings but I don't use those so can't comment on that.
trenn accepted request
While I took over the package some weeks ago and I cannot judge every detail, these changes make sense. Thanks!
Can you also test build on SLE 12 (SP5)?
You change the conditionals that reefer to SLE12 but did not try building on it.
Nevermind, it fails to build on SLE12 anyway:
[ 90s] File "gen_version.py", line 132 [ 90s] patch_version = f"{patch_version}~dev" [ 90s] ^ [ 90s] SyntaxError: invalid syntax
Beep?
@trenn: review reminder
@trenn - If there is no response during the next 3 days, I will just accept this.
Sorry, I was sick and locked up for some weeks...