This request supersedes:
request 954053
(Show diff)
Overview
Request 954300 accepted
Add 0002-unix-reproducible-directory-order-scandir.patch
to make zip file creation reproducible
- Add build time %check
- Created by bmwiedemann
- In state accepted
-
Package maintainers:
dspinella and
netsroth
- Supersedes 954053
Loading...
target maintainer
Would it be possible to implement the test in the codebase? I'd prefer to avoid maintaining the test manually in the spec file.
Login required, please
login
in order to comment
Request History
bmwiedemann created request
Add 0002-unix-reproducible-directory-order-scandir.patch
to make zip file creation reproducible
- Add build time %check
dspinella accepted request
Thank you!
I would like to point out to comment from original patch: "I am too lazy to add a switch to change how it is supposed to work. This is only a proof-of-concept." and it never got any reply from upstream ...
This patch came from the sourceforce infozip bugtracker, so if there is any upstream left, this is from as close from upstream as I could get. Also I do not see a need for a switch. We can just always have deterministic recursion order instead of random one from the filesystem. Or maybe he was referring to the case, where the OS does not provide a
scandirimplementation - but I guess we can leave those poor Windows users behind here.The "PoC" means he never tested it, but I did, found and fixed one bug and then it worked fine as established by the added test.
@dspinella, @netsroth: review reminder