Request 967938 (accepted)

Overview

Request 967938 accepted

- Update to current stable go1.18
Refs boo#1193742 go1.18 release tracking (forwarded request 967937 from jfkw)

Created by jfkw about 2 years ago
In state accepted

Submit go

Comments for request 967938 3

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

Breaks suseconnect-ng; https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:E/suseconnect-ng/standard/x86_64

Jeff Kowalczyk (jfkw) - about 2 years ago

author source maintainer

Thanks for the report. I will contact affected package maintainers (suseconnect-ng, lxd, container-diff) regarding options. Info for package maintainers at: https://go.dev/doc/go1.18#go-version. In most cases the new embedded build info could be sufficient to replace go list usage in packaging. If calling go list is deemed necessary, using the flag -buildvcs=false should mitigate the soft dependency on git.

packages/l/lxd/lxd.spec
171:    <<<"$(go list -f '{{.Name}}:{{.ImportPath}}' %{import_path}/... | \

packages/c/container-diff/container-diff.spec
76:PKG_LIST=$(go list ./... | grep -v "%{project}/vendor")

packages/s/suseconnect-ng/suseconnect-ng.spec
114:go list all

Jeff Kowalczyk (jfkw) - about 2 years ago

author source maintainer

suseconnect-ng SR https://build.opensuse.org/request/show/968305 has been submitted.

lxd and container-diff build in a branch test project without modifications: https://build.opensuse.org/project/show/home:jfkw:branches:devel:languages:go:golist-git-softdep

go1.18.1 will remove the embedding of VCS info in 'go test' binaries. It would be reasonable to defer/revoke this SR until go1.18.1 to prevent build failures of packages which do all of the following:

a) contain a git repository in the build sources, triggering detection

b) Call 'go test'

c) Do not transitively depend on git