Overview

Request 985249 accepted

- Update to 5.36.0

Loading...

Dominique Leuenberger's avatar

Breaks texlive and yast2-users


Michael Schröder's avatar

the texlive failure is due to a bug in biber-2.17 (i.e. in texlive). They assign to undef, which is forbidden.


Dominique Leuenberger's avatar

CC @WernerFink

perl 5.36 breaks texlive - @mlschroe debugged it to be:

the texlive failure is due to a bug in biber-2.17 (i.e. in texlive). They assign to undef, which is forbidden.

Full build log available at https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:A/texlive/standard/x86_64


Michael Schröder's avatar

yast2-users is weird, because it is a ruby package. perl is not involved.


Michael Schröder's avatar

Ok, it is a perl module. It's the test suite that's in ruby.

It's yast2-perl-bindings that needs fixing. It breaks because of the following change in perl:

Reading the string form of an integer value no longer sets the flag SVf_POK. The string form is still cached internally, and still re-read directly by the macros SvPV(sv) etc (inline, without calling a C function). XS code that already calls the APIs to get values will not be affected by this change. XS code that accesses flags directly instead of using API calls to express its intent might break, but such code likely is already buggy if passed some other values, such as floating point values or objects with string overloading.

YPerl::fromPerlScalarToAny contains this:

const char *pv = SvPV_nolen (sv);
if (SvPOK (sv))
{
    val = YCPString (pv);
}

The SvPV_nolen call no longer sets the POK flag, so this no longer works for numbers.

A fix would be to use SvPOK(sv) || SvIOK(sv) || SvNOK(sv) instead.


Michael Schröder's avatar

YPerl::fromPerlScalar also needs fixing


Request History
Michael Schröder's avatar

mlschroe created request

- Update to 5.36.0


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:A as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:A"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:A"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:A got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:A got accepted.

openSUSE Build Service is sponsored by