Hey there, this looks really good!

Some comments though:

• In _service you need to set changesauthor so the .changes file is correct
• rather than use cargo_install, you can just use an "install ..." line similar to '# install -m 0755 %{_builddir}/%{name}-%{version}/target/release/hellorust %{buildroot}%{_bindir}/hellorust' (It's in the example on https://en.opensuse.org/Packaging_Rust_Software )
• You have some rpm lint errors you may want to resolve:

[ 72s] zram-generator.src: E: unused-rpmlintrc-filter ".systemd-service-without-service." [ 72s] zram-generator.x86_64: E: no-changelogname-tag [ 72s] zram-generator.src: E: no-changelogname-tag [ 72s] There is no changelog. Please insert a '%changelog' section heading in your [ 72s] spec file and prepare your changes file using e.g. the 'osc vc' command.

Otherwise again looks good!

Benjamin Brunner (BenniBrunner) - over 2 years ago

@firstyear, thanks again for your feedback. I've changed cargo_install now to manually "install..." and also set the changesauthor in the service-file.

About the rpmlint errors, hm, I don't see those, neither in a local build nor in the remote build log. Maybe this was a leftover from a previous build.