Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
DISCONTINUED:openSUSE:11.1
grip
grip-3.2.0-ogg.patch
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File grip-3.2.0-ogg.patch of Package grip
- fix creation of genre comment when creating ogg vorbis files: Use eoggenc -G %G instead of using -G %g, otherwise only the mp3 genre number would be put into the comment field, but ogg uses a genre string. Update: keep old ginfo->selected_encoder, grip uses it in the config file as well, for more info see the comment below. --- grip-3.2.0/src/grip.c.orig 2004-04-15 20:23:54.000000000 +0200 +++ grip-3.2.0/src/grip.c 2004-09-16 17:24:23.616820713 +0200 @@ -856,10 +856,10 @@ *ginfo->wav_filter_cmd='\0'; *ginfo->disc_filter_cmd='\0'; - ginfo->selected_encoder=1; - strcpy(ginfo->mp3cmdline,"-h -b %b %w %m"); - FindExeInPath("lame", ginfo->mp3exename, sizeof(ginfo->mp3exename)); - strcpy(ginfo->mp3fileformat,"~/mp3/%A/%d/%n.%x"); - strcpy(ginfo->mp3extension,"mp3"); + ginfo->selected_encoder=6; /* oggenc's index in encoder_defaults[] */ + strcpy(ginfo->mp3cmdline,"-o %m -a %a -l %d -t %n -b %b %w -N %t -G %G -d %y"); + FindExeInPath("oggenc", ginfo->mp3exename, sizeof(ginfo->mp3exename)); + strcpy(ginfo->mp3fileformat,"~/mp3/%A/%d/%n.%x"); + strcpy(ginfo->mp3extension,"ogg"); ginfo->mp3nice=0; *ginfo->mp3_filter_cmd='\0'; ginfo->delete_wavs=TRUE; On the hunk below: This does the same (-G %g -> -G %G) for the list of encoders which are selectable, which also contains default values. grip saves the selected encoder by it's positoin in this table, so unless we add an entry called lice "encoder_num" to it and use this for loading and saving the selected_encoder value to the config file, we need to keep the original order of encoders. It also adds --best to the flac encoder line which enables maximum flac compression. The change in compressed size is not big but it does not affect decoding in practical terms and adds some more processing, but we can assume todays CPUs to be much faster than the relatively low error-correcting cdparanoia ripping speed where all sectors are read at least twice and the --best is quick to remove, should it be run on a 500 Mhz system. They should be rather rare nowadays. --- grip/src/gripcfg.c +++ grip/src/gripcfg.c @@ -47,9 +47,9 @@ static MP3Encoder encoder_defaults[]={{ "mp3"}, {"gogo","-b %b %w %m","mp3"}, {"oggenc", - "-o %m -a %a -l %d -t %n -b %b %w -N %t -G %g -d %y", + "-o %m -a %a -l %d -t %n -b %b %w -N %t -G %G -d %y", "ogg"}, - {"flac","-V -o %m %w","flac"}, + {"flac","--best -TTRACKNUMBER=%t -TALBUM=%d -TTITLE=%n -TARTIST=%a -TGENRE=%G -TDATE=%y -TDISCID=%i -TDESCRIPTION=\"Created by Grip\" -V -o %m %w","flac"}, {"other","",""}, {"",""} };
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor