File Fix-Plasma-crash.patch of Package ktp-desktop-applets

Overview Repositories Revisions Requests Users Attributes Meta

File Fix-Plasma-crash.patch of Package ktp-desktop-applets

From 2ff4c2a4a1e9b9ab8d11034399441d2e10d1ede0 Mon Sep 17 00:00:00 2001
From: Pavel Akopov <pak@basealt.ru>
Date: Thu, 17 Jan 2019 00:56:38 +0100
Subject: Fix Plasma crash when left click on unconfigured Person plasmoid

Summary

when left click on unconfigured Person plasmoid - plasmashell segfaulted.
plasmashell 5.12.6

kf5-kpeople-devel-5.47
kde5-ktp-desktop-applets-18.04.2

Test Plan

Add Person plasmoid to desktop.
    Do left click on it (plasmoid).
    segmentation faults...

Differential Revision: https://phabricator.kde.org/D14232
---
 person/org.kde.person/contents/ui/Person.qml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/person/org.kde.person/contents/ui/Person.qml b/person/org.kde.person/contents/ui/Person.qml
index c045b62..ac4e960 100644
--- a/person/org.kde.person/contents/ui/Person.qml
+++ b/person/org.kde.person/contents/ui/Person.qml
@@ -27,13 +27,17 @@ import org.kde.plasma.plasmoid 2.0
 
 PlasmaCore.IconItem {
     id: personPhoto
-    source: personData.person.photo
+    property bool isPersonSelected: (personData.personUri != "")
+    source: isPersonSelected ? personData.person.photo : "user"
 
     property int minActionWidth
 
     function actionTriggered(id)
     {
-        actions.triggerAction(id);
+        if (isPersonSelected)
+            actions.triggerAction(id);
+        else
+            plasmoid.action("configure").trigger();
     }
 
     MouseArea {
-- 
cgit v1.1

Places

File Fix-Plasma-crash.patch of Package ktp-desktop-applets

Places