File r874968-ebay-crash.diff of Package kdelibs3

Overview Repositories Revisions Requests Users Attributes Meta

File r874968-ebay-crash.diff of Package kdelibs3 (Revision 83dccd2046c21b2378fcf119df7ebdf0)

Currently displaying revision 83dccd2046c21b2378fcf119df7ebdf0 , Show latest

Index: khtml/rendering/table_layout.cpp
===================================================================
--- khtml/rendering/table_layout.cpp.orig
+++ khtml/rendering/table_layout.cpp
@@ -297,7 +297,8 @@ void FixedTableLayout::layout()
 #endif
         for ( int i = 0; available > 0 && i < nEffCols; i++ ) {
             if ( width[i].isPercent() ) {
-                int w = base * width[i].value() / totalPercent;
+                // totalPercent may be 0 below if all %-width specifed are 0%. (#172557)
+                int w = totalPercent ? base * width[i].value() / totalPercent : 0;
                 available -= w;
                 calcWidth[i] = w;
             }
@@ -313,7 +314,8 @@ void FixedTableLayout::layout()
 
         for ( int i = 0; available > 0 && i < nEffCols; i++ ) {
             if ( width[i].isVariable() ) {
-                int w = available / totalVariable;
+                // totalVariable may be 0 below if all the variable widths specified are 0.
+                int w = totalVariable ? available / totalVariable : 0;
                 available -= w;
                 calcWidth[i] = w;
 		totalVariable--;

Places

File r874968-ebay-crash.diff of Package kdelibs3 (Revision 83dccd2046c21b2378fcf119df7ebdf0)

Places