File 0002-QDBusPendingCall-add-a-missing-QWaitCondit... of Package libqt4

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-QDBusPendingCall-add-a-missing-QWaitCondition-wakeAl.patch of Package libqt4 (Revision 329b714d3bd88d4f8703267381db0671)

Currently displaying revision 329b714d3bd88d4f8703267381db0671 , Show latest

From 44f3fb1eec2041c6587d3347f103ca6fa0a17dad Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@kdab.com>
Date: Fri, 24 Aug 2012 10:27:02 +0200
Subject: [PATCH 2/6] QDBusPendingCall: add a missing QWaitCondition::wakeAll()
 call

In QDBusConnectionPrivate::waitForFinished(), threads that see
pcall->waitingForFinished == true go to sleep on
pcall->waitForFinishedCondition, but there was no call to
waitForFinishedCondition.wakeAll() anywhere in the code, so add it.

Change-Id: I8d068dc0cc4f20786eb40fd7e2bb9840d8b70c7f
(cherry-picked from qtbase commit 20d7763b19400c062a07f440cc601f486be4039b)
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
 src/dbus/qdbusintegrator.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/dbus/qdbusintegrator.cpp b/src/dbus/qdbusintegrator.cpp
index 96e4a12..15278b2 100644
--- a/src/dbus/qdbusintegrator.cpp
+++ b/src/dbus/qdbusintegrator.cpp
@@ -1782,6 +1782,7 @@ void QDBusConnectionPrivate::waitForFinished(QDBusPendingCallPrivate *pcall)
             // QDBusConnectionPrivate::processFinishedCall() is called automatically
         }
         pcall->mutex.lock();
+        pcall->waitForFinishedCondition.wakeAll();
     }
 }
 
-- 
1.8.3.1

Places

File 0002-QDBusPendingCall-add-a-missing-QWaitCondition-wakeAl.patch of Package libqt4 (Revision 329b714d3bd88d4f8703267381db0671)

Places