Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-12-SP1:GA
coreutils-testsuite
coreutils-avoid_clang_-Wtautological-constant-o...
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File coreutils-avoid_clang_-Wtautological-constant-out-of-range-compare_warning.patch of Package coreutils-testsuite
commit ffd1a1d8dee921e20db515e7d4b3c3e47006c8b4 Author: Pádraig Brady <P@draigBrady.com> Date: Mon May 12 15:46:43 2014 +0100 maint: avoid clang -Wtautological-constant-out-of-range-compare warning * src/df.c (decode_output_arg): Use only enum constants to avoid clang "warning: comparison of constant -1 with expression of type 'display_field_t' is always false" diff --git a/src/df.c b/src/df.c index a7fc57f..01ecca6 100644 --- a/src/df.c +++ b/src/df.c @@ -144,7 +144,8 @@ typedef enum IAVAIL_FIELD, /* inodes available */ IPCENT_FIELD, /* inodes used in percent */ TARGET_FIELD, /* mount point */ - FILE_FIELD /* specified file name */ + FILE_FIELD, /* specified file name */ + INVALID_FIELD /* validation marker */ } display_field_t; /* Flag if a field contains a block, an inode or another value. */ @@ -372,7 +373,7 @@ decode_output_arg (char const *arg) *comma++ = 0; /* process S. */ - display_field_t field = -1; + display_field_t field = INVALID_FIELD; for (unsigned int i = 0; i < ARRAY_CARDINALITY (field_data); i++) { if (STREQ (field_data[i].arg, s)) @@ -381,7 +382,7 @@ decode_output_arg (char const *arg) break; } } - if (field == -1) + if (field == INVALID_FIELD) { error (0, 0, _("option --output: field %s unknown"), quote (s)); usage (EXIT_FAILURE);
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor