File 0053-qcow2-Make-qcow2_alloc_bytes-more-e.patch of Package qemu-testsuite.1643

Overview Repositories Revisions Requests Users Attributes Meta

File 0053-qcow2-Make-qcow2_alloc_bytes-more-e.patch of Package qemu-testsuite.1643

From 0bcc356da211a2e5564c8f8d01d999dc40c26f68 Mon Sep 17 00:00:00 2001
From: Max Reitz <mreitz@redhat.com>
Date: Fri, 11 Sep 2015 18:47:51 +0200
Subject: [PATCH] qcow2: Make qcow2_alloc_bytes() more explicit

In case of -EAGAIN returned by update_refcount(), we should discard the
cluster offset we were trying to allocate and request a new one, because
in theory that old offset might now be taken by a refcount block.

In practice, this was not the case due to update_refcount() generally
returning strictly monotonic increasing cluster offsets. However, this
behavior is not set in stone, and it is also not obvious when looking at
qcow2_alloc_bytes() alone, so we should not rely on it.

Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 2ac01520be8717f3492b10a083c3e0e22cb52cda)
[BR: BSC#936537]
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 block/qcow2-refcount.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index d4f3351..479c410 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -963,11 +963,17 @@ int64_t qcow2_alloc_bytes(BlockDriverState *bs, int size)
 
             if (!offset || ROUND_UP(offset, s->cluster_size) != new_cluster) {
                 offset = new_cluster;
+                free_in_cluster = s->cluster_size;
+            } else {
+                free_in_cluster += s->cluster_size;
             }
         }
 
         assert(offset);
         ret = update_refcount(bs, offset, size, 1, false, QCOW2_DISCARD_NEVER);
+        if (ret < 0) {
+            offset = 0;
+        }
     } while (ret == -EAGAIN);
     if (ret < 0) {
         return ret;

Places

File 0053-qcow2-Make-qcow2_alloc_bytes-more-e.patch of Package qemu-testsuite.1643

Places