File CVE-2018-18849-qemuu-lsi53c895a-OOB-msg-buffer-... of Package xen.11319

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2018-18849-qemuu-lsi53c895a-OOB-msg-buffer-access-leads-to-DoS.patch of Package xen.11319

References: bsc#1114423 CVE-2018-18849

From: Prasad J Pandit <address@hidden>

While writing a message in 'lsi_do_msgin', message length value
in 'msg_len' could be invalid due to an invalid migration stream.
Add an assertion to avoid an out of bounds access, and reject
the incoming migration data if it contains an invalid message
length.

Discovered by Deja vu Security. Reported by Oracle.

Signed-off-by: Prasad J Pandit <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 hw/scsi/lsi53c895a.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Index: xen-4.4.4-testing/tools/qemu-xen-dir-remote/hw/scsi/lsi53c895a.c
===================================================================
--- xen-4.4.4-testing.orig/tools/qemu-xen-dir-remote/hw/scsi/lsi53c895a.c
+++ xen-4.4.4-testing/tools/qemu-xen-dir-remote/hw/scsi/lsi53c895a.c
@@ -823,10 +823,11 @@ static void lsi_do_status(LSIState *s)
 
 static void lsi_do_msgin(LSIState *s)
 {
-    int len;
+    uint8_t len;
     DPRINTF("Message in len=%d/%d\n", s->dbc, s->msg_len);
     s->sfbr = s->msg[0];
     len = s->msg_len;
+    assert(len > 0 && len <= LSI_MAX_MSGIN_LEN);
     if (len > s->dbc)
         len = s->dbc;
     pci_dma_write(PCI_DEVICE(s), s->dnad, s->msg, len);
@@ -1620,8 +1621,10 @@ static uint8_t lsi_reg_readb(LSIState *s
         return s->ccntl1;
     case 0x58: /* SBDL */
         /* Some drivers peek at the data bus during the MSG IN phase.  */
-        if ((s->sstat1 & PHASE_MASK) == PHASE_MI)
+        if ((s->sstat1 & PHASE_MASK) == PHASE_MI) {
+            assert(s->msg_len > 0);
             return s->msg[0];
+        }
         return 0;
     case 0x59: /* SBDL high */
         return 0;
@@ -1989,12 +1992,24 @@ static void lsi_pre_save(void *opaque)
     assert(QTAILQ_EMPTY(&s->queue));
 }
 
+static int lsi_post_load(void *opaque, int version_id)
+{
+    LSIState *s = opaque;
+
+    if (s->msg_len < 0 || s->msg_len > LSI_MAX_MSGIN_LEN) {
+        return -EINVAL;
+    }
+
+    return 0;
+}
+
 static const VMStateDescription vmstate_lsi_scsi = {
     .name = "lsiscsi",
     .version_id = 0,
     .minimum_version_id = 0,
     .minimum_version_id_old = 0,
     .pre_save = lsi_pre_save,
+    .post_load = lsi_post_load,
     .fields      = (VMStateField []) {
         VMSTATE_PCI_DEVICE(parent_obj, LSIState),

Places

File CVE-2018-18849-qemuu-lsi53c895a-OOB-msg-buffer-access-leads-to-DoS.patch of Package xen.11319

Places