File CVE-2016-5126-qemuu-buffer-overflow-in-iscsi_ai... of Package xen.5853

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2016-5126-qemuu-buffer-overflow-in-iscsi_aio_ioctl.patch of Package xen.5853

References: bsc#982286 CVE-2016-5126

From: 	Peter Lieven
Subject: 	[Qemu-block] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb
Date: 	Tue, 24 May 2016 10:59:28 +0200

at least in the path via virtio-blk the maximum size is not
restricted.

Cc: address@hidden
Signed-off-by: Peter Lieven <address@hidden>
---
 block/iscsi.c | 7 +++++++
 1 file changed, 7 insertions(+)

Index: xen-4.5.3-testing/tools/qemu-xen-dir-remote/block/iscsi.c
===================================================================
--- xen-4.5.3-testing.orig/tools/qemu-xen-dir-remote/block/iscsi.c
+++ xen-4.5.3-testing/tools/qemu-xen-dir-remote/block/iscsi.c
@@ -512,6 +512,13 @@ static BlockDriverAIOCB *iscsi_aio_ioctl
     acb->buf         = NULL;
     acb->ioh         = buf;
 
+    if (acb->ioh->cmd_len > SCSI_CDB_MAX_SIZE) {
+        error_report("iSCSI: ioctl error CDB exceeds max size (%d > %d)",
+                     acb->ioh->cmd_len, SCSI_CDB_MAX_SIZE);
+        qemu_aio_unref(acb);
+        return NULL;
+    }
+
     acb->task = malloc(sizeof(struct scsi_task));
     if (acb->task == NULL) {
         error_report("iSCSI: Failed to allocate task for scsi command. %s",

Places

File CVE-2016-5126-qemuu-buffer-overflow-in-iscsi_aio_ioctl.patch of Package xen.5853

Places