File 0107-main-remove-use-of-uninitialized-rv.patch of Package mdadm.5365

Overview Repositories Revisions Requests Users Attributes Meta

File 0107-main-remove-use-of-uninitialized-rv.patch of Package mdadm.5365

From 380487fdc9773fc93d2cb4f17560a067f87107ac Mon Sep 17 00:00:00 2001
From: NeilBrown <neilb@suse.com>
Date: Wed, 5 Aug 2015 14:53:33 +1000
Subject: [PATCH 159/359] main: remove use of uninitialized 'rv'.
References: bsc#1081910

If c.homecluster was not NULL, might get an
error anyway.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Coly Li <colyli@suse.de>

---
 mdadm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mdadm.c b/mdadm.c
index dcb49d0..5d5a1b8 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1293,11 +1293,12 @@ int main(int argc, char *argv[])
 		c.require_homehost = 0;
 	}
 
+	rv = 0;
 	if (c.homecluster == NULL && (c.nodes > 0)) {
 		c.homecluster = conf_get_homecluster();
 		if (c.homecluster == NULL)
 			rv = get_cluster_name(&c.homecluster);
-		if (rv != 0) {
+		if (rv) {
 			pr_err("The md can't get cluster name\n");
 			exit(1);
 		}
@@ -1322,7 +1323,6 @@ int main(int argc, char *argv[])
 		/* --scan implied --brief unless -vv */
 		c.brief = 1;
 
-	rv = 0;
 	switch(mode) {
 	case MANAGE:
 		/* readonly, add/remove, readwrite, runstop */
-- 
2.16.1

Places

File 0107-main-remove-use-of-uninitialized-rv.patch of Package mdadm.5365

Places