File pam_xauth-sigpipe.diff of Package pam.20951

Overview Repositories Revisions Requests Users Attributes Meta

File pam_xauth-sigpipe.diff of Package pam.20951

commit 47db675c910a065fa9602753a904b050b0322f29
Author: Dmitry V. Levin <ldv@altlinux.org>
Date:   Fri Jan 24 13:38:38 2014 +0000

pam_xauth: avoid potential SIGPIPE when writing to xauth process
    
    Similar issue in pam_unix was fixed by commit Linux-PAM-0-73~8.
    
    * modules/pam_xauth/pam_xauth.c (run_coprocess): In the parent process,
    close the read end of input pipe after writing to its write end.

modules/pam_xauth/pam_xauth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/modules/pam_xauth/pam_xauth.c b/modules/pam_xauth/pam_xauth.c
index 7075547..c7ce55a 100644
--- a/modules/pam_xauth/pam_xauth.c
+++ b/modules/pam_xauth/pam_xauth.c
@@ -179,12 +179,12 @@ run_coprocess(pam_handle_t *pamh, const char *input, char **output,
 	}
 
 	/* We're the parent, so close the other ends of the pipes. */
-	close(ipipe[0]);
 	close(opipe[1]);
 	/* Send input to the process (if we have any), then send an EOF. */
 	if (input) {
 		(void)pam_modutil_write(ipipe[1], input, strlen(input));
 	}
+	close(ipipe[0]); /* close here to avoid possible SIGPIPE above */
 	close(ipipe[1]);
 
 	/* Read data output until we run out of stuff to read. */
_______________________________________________
linux-pam-commits mailing list
linux-pam-commits@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/linux-pam-commits

Places

File pam_xauth-sigpipe.diff of Package pam.20951

Places