File 57da8883-credit1-fix-mask-to-be-used-for-tickling.patch of Package xen.4507
# Commit f83fc393b2bb0a8b97bca07d810684a2c709aaa8
# Date 2016-09-15 12:39:47 +0100
# Author Dario Faggioli <dario.faggioli@citrix.com>
# Committer George Dunlap <george.dunlap@citrix.com>
xen: credit1: fix mask to be used for tickling in Credit1
If there are idle pcpus inside the waking vcpu's
soft-affinity mask, we should really tickle one
of them (this is one of the purposes of the
__runq_tickle() function itself!), not just
any idle pcpu.
The issue has been introduced in 02ea5031825d
("credit1: properly deal with pCPUs not in any cpupool"),
where the usage of idle_mask is changed, without
updating the bottom of the function, where it
is also referenced.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -467,11 +467,12 @@ __runq_tickle(unsigned int cpu, struct c
if ( opt_tickle_one_idle )
{
this_cpu(last_tickle_cpu) =
- cpumask_cycle(this_cpu(last_tickle_cpu), &idle_mask);
+ cpumask_cycle(this_cpu(last_tickle_cpu),
+ csched_balance_mask(cpu));
cpumask_set_cpu(this_cpu(last_tickle_cpu), &mask);
}
else
- cpumask_or(&mask, &mask, &idle_mask);
+ cpumask_or(&mask, &mask, csched_balance_mask(cpu));
}
/* Did we find anyone? */