File curl-CVE-2016-8615.patch of Package curl

Overview Repositories Revisions Requests Users Attributes Meta

File curl-CVE-2016-8615.patch of Package curl (Revision c36b05fe17f4fff6f23c8f6132822958)

Currently displaying revision c36b05fe17f4fff6f23c8f6132822958 , Show latest

From 28867c2eb601e96a9205cce962b4898c4b9118de Mon Sep 17 00:00:00 2001
From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 27 Sep 2016 17:36:19 +0200
Subject: [PATCH] cookie: replace use of fgets() with custom version

... that will ignore lines that are too long to fit in the buffer.
---
 lib/cookie.c | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

Index: curl-7.37.0/lib/cookie.c
===================================================================
--- curl-7.37.0.orig/lib/cookie.c	2016-10-20 13:50:36.909954730 +0200
+++ curl-7.37.0/lib/cookie.c	2016-10-20 14:53:44.211404022 +0200
@@ -875,6 +875,35 @@ Curl_cookie_add(struct SessionHandle *da
   return co;
 }
 
+/*
+ * get_line() makes sure to only return complete whole lines that fit in 'len'
+ * bytes and end with a newline.
+ */
+static char *get_line(char *buf, int len, FILE *input)
+{
+  bool partial = FALSE;
+  while(1) {
+    char *b = fgets(buf, len, input);
+    if(b) {
+      size_t rlen = strlen(b);
+      if(rlen && (b[rlen-1] == '\n')) {
+        if(partial) {
+          partial = FALSE;
+          continue;
+        }
+        return b;
+      }
+      else
+        /* read a partial, discard the next piece that ends with newline */
+        partial = TRUE;
+    }
+    else
+      break;
+  }
+  return NULL;
+}
+
+
 /*****************************************************************************
  *
  * Curl_cookie_init()
@@ -926,7 +955,7 @@ struct CookieInfo *Curl_cookie_init(stru
 
     char *line = malloc(MAX_COOKIE_LINE);
     if(line) {
-      while(fgets(line, MAX_COOKIE_LINE, fp)) {
+      while(get_line(line, MAX_COOKIE_LINE, fp)) {
         if(checkprefix("Set-Cookie:", line)) {
           /* This is a cookie line, get it! */
           lineptr=&line[11];

Places

File curl-CVE-2016-8615.patch of Package curl (Revision c36b05fe17f4fff6f23c8f6132822958)

Places