File hg-CVE-2019-3902-fix3.patch of Package mercurial

Overview Repositories Revisions Requests Users Attributes Meta

File hg-CVE-2019-3902-fix3.patch of Package mercurial

# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1546953576 -32400
#      Tue Jan 08 22:19:36 2019 +0900
# Branch stable
# Node ID 83377b4b4ae0e9a6b8e579f7b0a693b8cf5c3b10
# Parent  6c10eba6b9cddab020de49fd4fabcb2cadcd85d0
subrepo: reject potentially unsafe subrepo paths (BC) (SEC)

In addition to the previous patch, this prohibits '~', '$nonexistent', etc.
for any subrepo types. I think this is safer, and real-world subrepos wouldn't
use such (local) paths.

---
 mercurial/subrepo.py |    4 ++++
 1 file changed, 4 insertions(+)

--- a/mercurial/subrepo.py
+++ b/mercurial/subrepo.py
@@ -335,6 +335,10 @@ def itersubrepos(ctx1, ctx2):
         yield subpath, ctx.sub(subpath)
 
 def _auditsubrepopath(repo, path):
+    # sanity check for potentially unsafe paths such as '~' and '$FOO'
+    if path.startswith('~') or '$' in path or util.expandpath(path) != path:
+        raise error.Abort(_('subrepo path contains illegal component: %s')
+                          % path)
     # auditor doesn't check if the path itself is a symlink
     scmutil.pathauditor(repo.root)(path)
     if repo.wvfs.islink(path):

Places

File hg-CVE-2019-3902-fix3.patch of Package mercurial

Places