File CVE-2020-7211-qemuu-slirp-potential-directory-traversal-using-relative-paths.patch of Package xen.14030
tftp restricts relative or directory path access on Linux systems.
Apply same restrictions on Windows systems too. It helps to avoid
directory traversal issue.
Fixes: https://bugs.launchpad.net/qemu/+bug/1812451Reported-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPrasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Samuel Thibault's avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
Message-Id: <20200113121431.156708-1-ppandit@redhat.com>
Index: xen-4.5.5-testing/tools/qemu-xen-dir-remote/slirp/tftp.c
===================================================================
--- xen-4.5.5-testing.orig/tools/qemu-xen-dir-remote/slirp/tftp.c
+++ xen-4.5.5-testing/tools/qemu-xen-dir-remote/slirp/tftp.c
@@ -323,9 +323,13 @@ static void tftp_handle_rrq(Slirp *slirp
k += 6; /* skipping octet */
/* do sanity checks on the filename */
- if (!strncmp(req_fname, "../", 3) ||
- req_fname[strlen(req_fname) - 1] == '/' ||
- strstr(req_fname, "/../")) {
+ if (
+#ifdef G_OS_WIN32
+ strstr(req_fname, "..\\") ||
+ req_fname[strlen(req_fname) - 1] == '\\' ||
+#endif
+ strstr(req_fname, "../") ||
+ req_fname[strlen(req_fname) - 1] == '/') {
tftp_send_error(spt, 2, "Access violation", tp);
return;
}