File 0004-fix-broken-check.patch of Package apache2-mod_fastcgi.863

Overview Repositories Revisions Requests Users Attributes Meta

File 0004-fix-broken-check.patch of Package apache2-mod_fastcgi.863

From: Yehuda Sadeh <yehuda@hq.newdream.net>
Date: Mon, 1 Aug 2011 14:22:36 -0700
Subject: [PATCH] fix broken check

a recent commit that fixed the expect header check, actually broke
it completely, as env->name is not null terminated.
---
 fcgi_protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fcgi_protocol.c b/fcgi_protocol.c
index bc9f487..e8f12af 100644
--- a/fcgi_protocol.c
+++ b/fcgi_protocol.c
@@ -256,7 +256,7 @@ int fcgi_protocol_queue_env(request_rec *r, fcgi_request *fr, env_status *env,
 	    ap_log_error(FCGI_LOG_WARN_NOERRNO, fcgi_apache_main_server,
 			"FastCGI: name='%.*s' val='%.*s'", env->nameLen, *env->envp, env->valueLen, val);
 	    if (val && env->nameLen == sizeof("HTTP_EXPECT") - 1 &&
-                strcasecmp(name, "HTTP_EXPECT") == 0 &&
+                strncasecmp(name, "HTTP_EXPECT", env->nameLen) == 0 &&
                 strcasecmp(val, "100-continue") == 0)
 		*expect_cont = 1;
             build_env_header(env->nameLen, env->valueLen, env->headerBuff, &env->headerLen);

Places

File 0004-fix-broken-check.patch of Package apache2-mod_fastcgi.863

Places