File 0001-image-fix-crash-in-fill_xrgb32_lerp_opaque... of Package cairo.2934

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-image-fix-crash-in-fill_xrgb32_lerp_opaque_spans.patch of Package cairo.2934 (Revision 18bb26f4c208af4a48a8f169cfa9fe77)

Currently displaying revision 18bb26f4c208af4a48a8f169cfa9fe77 , Show latest

From 5c82d91a5e15d29b1489dcb413b24ee7fdf59934 Mon Sep 17 00:00:00 2001
From: Bryce Harrington <bryce@osg.samsung.com>
Date: Wed, 3 Dec 2014 19:28:15 -0800
Subject: image: Fix crash in _fill_xrgb32_lerp_opaque_spans

If a span length is negative don't go out of bounds processing the fill
data.

Patch thanks to Ilya Sakhnenko <ilia.softway@gmail.com> on mailing list.

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>

diff --git a/src/cairo-image-compositor.c b/src/cairo-image-compositor.c
index 6ff0f09..48072f8 100644
--- a/src/cairo-image-compositor.c
+++ b/src/cairo-image-compositor.c
@@ -2205,10 +2205,10 @@ _fill_xrgb32_lerp_opaque_spans (void *abstract_renderer, int y, int h,
 				     spans[0].x, y, len, 1, r->u.fill.pixel);
 		    } else {
 			uint32_t *d = (uint32_t*)(r->u.fill.data + r->u.fill.stride*y + spans[0].x*4);
-			while (len--)
+			while (len-- > 0)
 			    *d++ = r->u.fill.pixel;
 		    }
-		} else while (len--) {
+		} else while (len-- > 0) {
 		    *d = lerp8x4 (r->u.fill.pixel, a, *d);
 		    d++;
 		}
-- 
cgit v0.10.2

Places

File 0001-image-fix-crash-in-fill_xrgb32_lerp_opaque_spans.patch of Package cairo.2934 (Revision 18bb26f4c208af4a48a8f169cfa9fe77)

Places