File 0006-rsa-rsa_eay.c-make-RSAerr-call-in-rsa_ossl... of Package compat-openssl098

Overview Repositories Revisions Requests Users Attributes Meta

File 0006-rsa-rsa_eay.c-make-RSAerr-call-in-rsa_ossl_private_d.patch of Package compat-openssl098 (Revision 47d995763155c8d5b237e0b3a911e115)

Currently displaying revision 47d995763155c8d5b237e0b3a911e115 , Show latest

From 3b776fd785efb1c0af4b28ad0b8036b23071904d Mon Sep 17 00:00:00 2001
From: Andy Polyakov <appro@openssl.org>
Date: Fri, 30 Nov 2018 21:07:18 +0100
Subject: [PATCH 2/5] rsa/rsa_eay.c: make RSAerr call in
 rsa_ossl_private_decrypt unconditional.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 89072e0c2a483f2ad678e723e112712567b0ceb1)

(Merged from https://github.com/openssl/openssl/pull/7737)
---
 crypto/rsa/rsa_eay.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: openssl-0.9.8j/crypto/rsa/rsa_eay.c
===================================================================
--- openssl-0.9.8j.orig/crypto/rsa/rsa_eay.c
+++ openssl-0.9.8j/crypto/rsa/rsa_eay.c
@@ -114,6 +114,7 @@
 #include <openssl/bn.h>
 #include <openssl/rsa.h>
 #include <openssl/rand.h>
+#include "constant_time_locl.h"
 
 #if !defined(RSA_NULL) && !defined(OPENSSL_FIPS)
 
@@ -580,8 +581,8 @@ static int RSA_eay_private_decrypt(int f
 		RSAerr(RSA_F_RSA_EAY_PRIVATE_DECRYPT,RSA_R_UNKNOWN_PADDING_TYPE);
 		goto err;
 		}
-	if (r < 0)
-		RSAerr(RSA_F_RSA_EAY_PRIVATE_DECRYPT,RSA_R_PADDING_CHECK_FAILED);
+	RSAerr(RSA_F_RSA_EAY_PRIVATE_DECRYPT, RSA_R_PADDING_CHECK_FAILED);
+	err_clear_last_constant_time(r >= 0);
 
 err:
 	if (ctx != NULL)

Places

File 0006-rsa-rsa_eay.c-make-RSAerr-call-in-rsa_ossl_private_d.patch of Package compat-openssl098 (Revision 47d995763155c8d5b237e0b3a911e115)

Places