Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-12-SP3:GA
iproute2.5568
iproute-fix-documentation-for-ip-rule-scan-orde...
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File iproute-fix-documentation-for-ip-rule-scan-order-2.patch of Package iproute2.5568
From: Phil Sutter <phil@nwl.cc> Date: Thu, 8 Sep 2016 12:33:03 +0200 Subject: iproute: fix documentation for ip rule scan order Patch-mainline: v4.9.0 Git-commit: 31a29009c5e921e81ff8419c482f826de5a1a493 References: bsc#990635 Hi, On Thu, Sep 08, 2016 at 11:59:55AM +0200, Michal Kubecek wrote: > On Thu, Sep 01, 2016 at 09:04:54AM -0700, Stephen Hemminger wrote: > > On Tue, 30 Aug 2016 17:32:52 -0700 > > Iskren Chernev <iskren@imo.im> wrote: > > > > > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001 > > > From: Iskren Chernev <iskren@imo.im> > > > Date: Tue, 30 Aug 2016 17:08:54 -0700 > > > Subject: [PATCH bug-fix] iproute: fix documentation for ip rule scan order > > > > > > --- > > > man/man8/ip-rule.8 | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 > > > index 1774ae3..3508d80 100644 > > > --- a/man/man8/ip-rule.8 > > > +++ b/man/man8/ip-rule.8 > > > @@ -93,7 +93,7 @@ Each policy routing rule consists of a > > > .B selector > > > and an > > > .B action predicate. > > > -The RPDB is scanned in order of decreasing priority. The selector > > > +The RPDB is scanned in order of increasing priority. The selector > > > of each rule is applied to {source address, destination address, > > > incoming > > > interface, tos, fwmark} and, if the selector matches the packet, > > > the action is performed. The action predicate may return with success. > > > -- > > > 2.4.5 > > > > Applied > > I'm sorry I didn't notice before but this just reverts the change done > by commit 49572501664d ("iproute2: clarification of various man8 pages"). > IMHO the problem is that both versions are equally confusing as the word > "priority" can be understood in two different senses. > > How about more explicit formulation, e.g. > > ... in order of decreasing logical priority (i.e. increasing numeric > values). > > Would that be better? Looks like the real issue is missing definition of priority. What about this: Acked-by: Michal Kubecek <mkubecek@suse.cz> --- man/man8/ip-rule.8 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 index 2c1e8260ab5a..dc93ffb0adae 100644 --- a/man/man8/ip-rule.8 +++ b/man/man8/ip-rule.8 @@ -86,7 +86,7 @@ Each policy routing rule consists of a .B selector and an .B action predicate. -The RPDB is scanned in order of increasing priority. The selector +The RPDB is scanned in order of decreasing priority. The selector of each rule is applied to {source address, destination address, incoming interface, tos, fwmark} and, if the selector matches the packet, the action is performed. The action predicate may return with success. @@ -216,8 +216,10 @@ value to match. .TP .BI priority " PREFERENCE" -the priority of this rule. Each rule should have an explicitly -set +the priority of this rule. +.I PREFERENCE +is an unsigned integer value, higher number means lower priority. Each rule +should have an explicitly set .I unique priority value. The options preference and order are synonyms with priority. -- 2.13.2
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor