Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-12-SP3:GA
iproute2.5568
routel-fix-infinite-loop-in-line-parser.patch
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File routel-fix-infinite-loop-in-line-parser.patch of Package iproute2.5568
From: =?UTF-8?q?Michal=20Kube=C4=8Dek?= <mkubecek@suse.cz> Date: Thu, 27 Apr 2017 11:43:47 +0200 Subject: routel: fix infinite loop in line parser Patch-mainline: v4.11.0 Git-commit: 6ec14f1abb82bdaa6d0fd98e491a505bcd284d26 References: bsc#1034855 As noticed by one of the few users of routel script, it ends up in an infinite loop when they pull out the cable from the NIC used for some route. This is caused by its parser expecting the line of "ip route show" output consists of "key value" pairs (except for the initial target range), together with an old trap of Bourne style shells that "shift 2" does nothing if there is only one argument left. Some keywords, e.g. "linkdown", are not followed by a value. Improve the parser to (1) only set variables for keywords we care about (2) recognize (currently) known keywords without value This is still far from perfect (and certainly not future proof) but to fully fix the script, one would probably have to rewrite the logic completely (and I'm not sure it's worth the effort). Signed-off-by: Michal Kubecek <mkubecek@suse.cz> --- ip/routel | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/ip/routel b/ip/routel index 8d1d352abdff..9a30462aa6b2 100644 --- a/ip/routel +++ b/ip/routel @@ -32,10 +32,22 @@ ip route list table "$@" | esac while test $# != 0 do - key=$1 - val=$2 - eval "$key=$val" - shift 2 + case "$1" in + proto|via|dev|scope|src|table) + key=$1 + val=$2 + eval "$key='$val'" + shift 2 + ;; + dead|onlink|pervasive|offload|notify|linkdown|unresolved) + shift + ;; + *) + # avoid infinite loop on unknown keyword without value at line end + shift + shift + ;; + esac done echo "$network $via $src $proto $scope $dev $table" done | awk -F ' ' ' -- 2.13.2
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor