File 1ac897a1-cmt-fix2.patch of Package libvirt.5678

Overview Repositories Revisions Requests Users Attributes Meta

File 1ac897a1-cmt-fix2.patch of Package libvirt.5678

commit 1ac897a15da11d1bfca2642bce3b0beaad32bcf1
Author: Jiri Denemark <jdenemar@redhat.com>
Date:   Tue Jun 28 11:12:41 2016 +0200

cpu_x86: Properly drop non-migratable features
    
    By removing a non-migratable feature in a for loop we would fail to drop
    every second non-migratable feature if the features array contained
    several of them in a row.
    
    Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

Index: libvirt-2.0.0/src/cpu/cpu_x86.c
===================================================================
--- libvirt-2.0.0.orig/src/cpu/cpu_x86.c
+++ libvirt-2.0.0/src/cpu/cpu_x86.c
@@ -1816,8 +1816,11 @@ x86Decode(virCPUDefPtr cpu,
      * Note: this only works as long as no CPU model contains non-migratable
      * features directly */
     if (flags & VIR_CONNECT_BASELINE_CPU_MIGRATABLE) {
-        for (i = 0; i < cpuModel->nfeatures; i++) {
-            if (!x86FeatureIsMigratable(cpuModel->features[i].name, map)) {
+        i = 0;
+        while (i < cpuModel->nfeatures) {
+            if (x86FeatureIsMigratable(cpuModel->features[i].name, map)) {
+                i++;
+            } else {
                 VIR_FREE(cpuModel->features[i].name);
                 VIR_DELETE_ELEMENT_INPLACE(cpuModel->features, i,
                                            cpuModel->nfeatures);
@@ -2542,8 +2545,11 @@ x86UpdateHostModel(virCPUDefPtr guest,
     /* Remove non-migratable features by default
      * Note: this only works as long as no CPU model contains non-migratable
      * features directly */
-    for (i = 0; i < guest->nfeatures; i++) {
-        if (!x86FeatureIsMigratable(guest->features[i].name, map)) {
+    i = 0;
+    while (i < guest->nfeatures) {
+        if (x86FeatureIsMigratable(guest->features[i].name, map)) {
+            i++;
+        } else {
             VIR_FREE(guest->features[i].name);
             VIR_DELETE_ELEMENT_INPLACE(guest->features, i, guest->nfeatures);
         }

Places

File 1ac897a1-cmt-fix2.patch of Package libvirt.5678

Places