File 0027-Grow-fix-resize-of-array-component-size-to... of Package mdadm.5365

Overview Repositories Revisions Requests Users Attributes Meta

File 0027-Grow-fix-resize-of-array-component-size-to-32bits.patch of Package mdadm.5365

From 0448027b765ec7ede580a1630c23fe7cf4bd0b05 Mon Sep 17 00:00:00 2001
From: Justin Maggard <jmaggard10@gmail.com>
Date: Fri, 24 Oct 2014 17:55:02 -0700
Subject: [PATCH 037/359] Grow: fix resize of array component size to > 32bits
References: bsc#1081910

If the request --size to --grow an array to is larger
than 32bits, then mdadm may make the wrong choice and
use ioctl instead of setting component_size via sysfs
and the change is ignored.

Instead of using casts to check for a 32-bit overflow,
just check for set bits outside of INT32_MAX.

Fixes: 4e9a3dd16d656b269f5602624ac4f7109a571368
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Coly Li <colyli@suse.de>

---
 Grow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Grow.c b/Grow.c
index 76bb35a..a0f7526 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1818,7 +1818,7 @@ int Grow_reshape(char *devname, int fd,
 		if (s->size == MAX_SIZE)
 			s->size = 0;
 		array.size = s->size;
-		if (array.size != (signed)s->size) {
+		if (s->size & ~INT32_MAX) {
 			/* got truncated to 32bit, write to
 			 * component_size instead
 			 */
-- 
2.16.1

Places

File 0027-Grow-fix-resize-of-array-component-size-to-32bits.patch of Package mdadm.5365

Places