File openssh-cve-2023-51385.patch of Package openssh-askpass-gnome

Overview Repositories Revisions Requests Users Attributes Meta

File openssh-cve-2023-51385.patch of Package openssh-askpass-gnome

Index: openssh-7.9p1/ssh.c
===================================================================
--- openssh-7.9p1.orig/ssh.c
+++ openssh-7.9p1/ssh.c
@@ -575,6 +575,41 @@ set_addrinfo_port(struct addrinfo *addrs
 	}
 }
 
+static int
+valid_hostname(const char *s)
+{
+	size_t i;
+
+	if (*s == '-')
+		return 0;
+	for (i = 0; s[i] != 0; i++) {
+		if (strchr("'`\"$\\;&<>|(){}", s[i]) != NULL ||
+		    isspace((u_char)s[i]) || iscntrl((u_char)s[i]))
+			return 0;
+	}
+	return 1;
+}
+
+static int
+valid_ruser(const char *s)
+{
+	size_t i;
+
+	if (*s == '-')
+		return 0;
+	for (i = 0; s[i] != 0; i++) {
+		if (strchr("'`\";&<>|(){}", s[i]) != NULL)
+			return 0;
+		/* Disallow '-' after whitespace */
+		if (isspace((u_char)s[i]) && s[i + 1] == '-')
+			return 0;
+		/* Disallow \ in last position */
+		if (s[i] == '\\' && s[i + 1] == '\0')
+			return 0;
+	}
+	return 1;
+}
+
 /*
  * Main program for the ssh client.
  */
@@ -1040,6 +1075,11 @@ main(int ac, char **av)
 	if (!host)
 		usage();
 
+	if (!valid_hostname(host))
+		fatal("hostname contains invalid characters");
+	if (options.user != NULL && !valid_ruser(options.user))
+		fatal("remote username contains invalid characters");
+
 	host_arg = xstrdup(host);
 
 #ifdef WITH_OPENSSL

Places

File openssh-cve-2023-51385.patch of Package openssh-askpass-gnome

Places