File blockcopy-check-dst-identical-device.patch of Package libvirt.8090

Overview Repositories Revisions Requests Users Attributes Meta

File blockcopy-check-dst-identical-device.patch of Package libvirt.8090

From 475b272c126d53f3985860422dc96b01b470423e Mon Sep 17 00:00:00 2001
From: Chunyan Liu <cyliu@suse.com>
Date: Tue, 29 Jul 2014 17:31:28 +0800
Subject: [PATCH] blockcopy: check dst = identical device

Check whether dst is the same device as source, if yes, report
error and exit.

Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
 src/qemu/qemu_driver.c | 7 +++++++
 1 file changed, 7 insertions(+)

Index: libvirt-1.2.18.4/src/qemu/qemu_driver.c
===================================================================
--- libvirt-1.2.18.4.orig/src/qemu/qemu_driver.c
+++ libvirt-1.2.18.4/src/qemu/qemu_driver.c
@@ -16701,6 +16701,15 @@ qemuDomainBlockCopyCommon(virDomainObjPt
                        _("non-file destination not supported yet"));
         goto endjob;
     }
+
+    if (STREQ_NULLABLE(realpath(disk->src->path, NULL),
+                       realpath(mirror->path, NULL))) {
+        virReportError(VIR_ERR_INVALID_ARG,
+                       _("destination '%s' is the same as disk '%s' source"),
+                       mirror->path, path);
+        goto endjob;
+    }
+
     if (stat(mirror->path, &st) < 0) {
         if (errno != ENOENT) {
             virReportSystemError(errno, _("unable to stat for disk %s: %s"),

Places

File blockcopy-check-dst-identical-device.patch of Package libvirt.8090

Places