File 0275-net-vmxnet-use-g_new-for-pkt-initia.patch of Package qemu-linux-user.4227

Overview Repositories Revisions Requests Users Attributes Meta

File 0275-net-vmxnet-use-g_new-for-pkt-initia.patch of Package qemu-linux-user.4227

From 008920da83a5db9235ef7bb3bd47dca5b89636d0 Mon Sep 17 00:00:00 2001
From: Li Qiang <liqiang6-s@360.cn>
Date: Tue, 16 Aug 2016 16:58:01 +0530
Subject: [PATCH] net: vmxnet: use g_new for pkt initialisation

When network transport abstraction layer initialises pkt, the maximum
fragmentation count is not checked. This could lead to an integer
overflow causing a NULL pointer dereference. Replace g_malloc() with
g_new() to catch the multiplication overflow.

Reported-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Acked-by: Dmitry Fleytman <dmitry@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 47882fa4975bf0b58dd74474329fdd7154e8f04c)
[BR: CVE-2016-6833 BSC#994774]
Signed-off-by: Bruce Rogers <brogers@suse.com>

Conflicts:
	hw/net/vmxnet_tx_pkt.c
---
 hw/net/vmxnet_tx_pkt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/net/vmxnet_tx_pkt.c b/hw/net/vmxnet_tx_pkt.c
index eb88ddf254..c12f522167 100644
--- a/hw/net/vmxnet_tx_pkt.c
+++ b/hw/net/vmxnet_tx_pkt.c
@@ -59,10 +59,9 @@ void vmxnet_tx_pkt_init(struct VmxnetTxPkt **pkt, uint32_t max_frags,
 {
     struct VmxnetTxPkt *p = g_malloc0(sizeof *p);
 
-    p->vec = g_malloc((sizeof *p->vec) *
-        (max_frags + VMXNET_TX_PKT_PL_START_FRAG));
+    p->vec = g_new(struct iovec, max_frags + VMXNET_TX_PKT_PL_START_FRAG);
 
-    p->raw = g_malloc((sizeof *p->raw) * max_frags);
+    p->raw = g_new(struct iovec, max_frags);
 
     p->max_payload_frags = max_frags;
     p->max_raw_frags = max_frags;

Places

File 0275-net-vmxnet-use-g_new-for-pkt-initia.patch of Package qemu-linux-user.4227

Places