File 4c600de7-libxl-schedinfo.patch of Package libvirt.10498

Overview Repositories Revisions Requests Users Attributes Meta

File 4c600de7-libxl-schedinfo.patch of Package libvirt.10498

commit 4c600de755d39fb316ad89710257679b4850ac71
Author: Jim Fehlig <jfehlig@suse.com>
Date:   Tue Sep 27 22:18:50 2016 -0600

libxl: fix param assignment in domainGetSchedulerParameters
    
    Due to a copy and paste error, the scheduler 'cap' parameter
    was over-writing the 'weight' parameter when preparing the
    return parameters in libxlDomainGetSchedulerParametersFlags.
    As a result, the scheduler weight was never shown when getting
    schedinfo and setting the weight failed as well
    
    virsh  schedinfo testvm
    Scheduler      : credit
    cap            : 0
    
    virsh  schedinfo testvm --cap 50 --weight 500
    Scheduler      : credit
    error: invalid scheduler option: weight
    
    The obvious fix is to assign the 'caps' parameter to the correct
    item in the parameter list.
    
    Reported-by: Volo M. <vm@vovs.net>

Index: libvirt-2.0.0/src/libxl/libxl_driver.c
===================================================================
--- libvirt-2.0.0.orig/src/libxl/libxl_driver.c
+++ libvirt-2.0.0/src/libxl/libxl_driver.c
@@ -4480,7 +4480,7 @@ libxlDomainGetSchedulerParametersFlags(v
         goto cleanup;
 
     if (*nparams > 1) {
-        if (virTypedParameterAssign(&params[0], VIR_DOMAIN_SCHEDULER_CAP,
+        if (virTypedParameterAssign(&params[1], VIR_DOMAIN_SCHEDULER_CAP,
                                     VIR_TYPED_PARAM_UINT, sc_info.cap) < 0)
             goto cleanup;
     }

Places

File 4c600de7-libxl-schedinfo.patch of Package libvirt.10498

Places