File 0016-iniparser-dictionary_set-must-return-a-val... of Package openwsman

Overview Repositories Revisions Requests Users Attributes Meta

File 0016-iniparser-dictionary_set-must-return-a-value.patch of Package openwsman (Revision 10747162fe29108765aa47980ad920af)

Currently displaying revision 10747162fe29108765aa47980ad920af , Show latest

From 112137c1073fe5d660f8a12fccf21997eb228e4d Mon Sep 17 00:00:00 2001
From: David Holm <dholmster@gmail.com>
Date: Sat, 23 Aug 2014 20:38:01 +0200
Subject: [PATCH 16/16] iniparser: `dictionary_set' must return a value.

The `dictionary_set' function is supposed to return an integer but in
two cases it was not leading to a build error when using Clang 3.4.
---
 src/lib/u/iniparser.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/u/iniparser.c b/src/lib/u/iniparser.c
index 1c269583254c..789bbf87ae7f 100644
--- a/src/lib/u/iniparser.c
+++ b/src/lib/u/iniparser.c
@@ -331,7 +331,7 @@ static int dictionary_set(dictionary * d, char * key, char * val)
     int         i ;
     unsigned    hash ;
 
-    if (d==NULL || key==NULL) return ;
+    if (d==NULL || key==NULL) return 1 ;
 
     /* Compute hash for this key */
     hash = dictionary_hash(key) ;
@@ -347,7 +347,7 @@ static int dictionary_set(dictionary * d, char * key, char * val)
                         free(d->val[i]);
                     d->val[i] = val ? strdup(val) : NULL ;
                     /* Value has been modified: return */
-                    return ;
+                    return 0 ;
                 }
             }
         }
-- 
2.18.0

Places

File 0016-iniparser-dictionary_set-must-return-a-value.patch of Package openwsman (Revision 10747162fe29108765aa47980ad920af)

Places