File 0003-quic-Check-RLE-lengths.patch of Package spice.19892
From f0d36ed686902d1fb19b17cf08acc6c0319d0d73 Mon Sep 17 00:00:00 2001
From: Frediano Ziglio <freddy77@gmail.com>
Date: Wed, 29 Apr 2020 15:11:38 +0100
Subject: [PATCH 3/4] quic: Check RLE lengths
Avoid buffer overflows decoding images. On compression we compute
lengths till end of line so it won't cause regressions.
Proved by fuzzing the code.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Uri Lublin <uril@redhat.com>
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
spice-common/common/quic_tmpl.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletion(-)
diff --git a/spice-common/common/quic_tmpl.c b/spice-common/common/quic_tmpl.c
index c2a1b66..14b86f4 100644
--- a/spice-common/common/quic_tmpl.c
+++ b/spice-common/common/quic_tmpl.c
@@ -563,10 +563,14 @@ do_run:
channel->state.waitcnt = stopidx - i;
run_index = i;
#ifdef RLE_STAT
- run_end = i + decode_channel_run(encoder, channel);
+ run_end = decode_channel_run(encoder, channel);
#else
- run_end = i + decode_run(encoder);
+ run_end = decode_run(encoder);
#endif
+ if (run_end < 0 || run_end > (end - i)) {
+ encoder->usr->error(encoder->usr, "wrong RLE\n");
+ }
+ run_end += i;
for (; i < run_end; i++) {
cur_row[i].a = cur_row[i - 1].a;
--
2.28.0