File qtbase-bmp-image-handler-check-for-out-of-range... of Package libqt5-qtbase

Overview Repositories Revisions Requests Users Attributes Meta

File qtbase-bmp-image-handler-check-for-out-of-range-image-size.patch of Package libqt5-qtbase (Revision 1813ae35414dd18344454d27186db9e0)

Currently displaying revision 1813ae35414dd18344454d27186db9e0 , Show latest

From 5104a529ce5aea5e94101770ece188b98f20baaa Mon Sep 17 00:00:00 2001
From: Eirik Aavitsland <eirik.aavitsland@qt.io>
Date: Tue, 4 Sep 2018 11:08:06 +0200
Subject: [PATCH] bmp image handler: check for out of range image size

Make the decoder fail early to avoid spending time and memory on
attempting to decode a corrupt image file.

Change-Id: I874e04f3b43122d73f8e58c7a5bcc4a741b68264
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
(cherry picked from commit 621ab8ab59901cc3f9bd98be709929c9eac997a8)
Reviewed-by: Liang Qi <liang.qi@qt.io>
---
 src/gui/image/qbmphandler.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gui/image/qbmphandler.cpp b/src/gui/image/qbmphandler.cpp
index 703c5c0f31..6990d69b35 100644
--- a/src/gui/image/qbmphandler.cpp
+++ b/src/gui/image/qbmphandler.cpp
@@ -188,6 +188,8 @@ static bool read_dib_infoheader(QDataStream &s, BMP_INFOHDR &bi)
     if (!(comp == BMP_RGB || (nbits == 4 && comp == BMP_RLE4) ||
         (nbits == 8 && comp == BMP_RLE8) || ((nbits == 16 || nbits == 32) && comp == BMP_BITFIELDS)))
          return false;                                // weird compression type
+    if (bi.biWidth < 0 || quint64(bi.biWidth) * qAbs(bi.biHeight) > 16384 * 16384)
+        return false;
 
     return true;
 }
-- 
2.16.4

Places

File qtbase-bmp-image-handler-check-for-out-of-range-image-size.patch of Package libqt5-qtbase (Revision 1813ae35414dd18344454d27186db9e0)

Places