File pacemaker-libcrmcommon-handle-compression-failu... of Package pacemaker.10804

Overview Repositories Revisions Requests Users Attributes Meta

File pacemaker-libcrmcommon-handle-compression-failures-properly.patch of Package pacemaker.10804

commit 88eaf594a3f0fec801e3edd5983741b7ae0f557f
Author: Ken Gaillot <kgaillot@redhat.com>
Date:   Wed Apr 4 18:56:37 2018 -0500

Low: libcrmcommon: handle compression failures properly
    
    Previous code set an unsigned variable to -1 and later tested it < 0

diff --git a/lib/common/xml.c b/lib/common/xml.c
index 98c1f569c..7781d48a0 100644
--- a/lib/common/xml.c
+++ b/lib/common/xml.c
@@ -3098,10 +3098,10 @@ write_xml_stream(xmlNode * xml_node, const char *filename, FILE * stream, gboole
                 crm_warn("Not compressing %s: could not write compressed data: %s "
                          CRM_XS " bzerror=%d errno=%d",
                          filename, bz2_strerror(rc), rc, errno);
-                out = -1; // retry without compression
+                out = 0; // retry without compression
             } else {
                 res = (int) out;
-                crm_trace("Compressed XML for %s from %d bytes to %d",
+                crm_trace("Compressed XML for %s from %u bytes to %u",
                           filename, in, out);
             }
         }
@@ -3110,7 +3110,7 @@ write_xml_stream(xmlNode * xml_node, const char *filename, FILE * stream, gboole
 #endif
     }
 
-    if (out <= 0) {
+    if (out == 0) {
         res = fprintf(stream, "%s", buffer);
         if (res < 0) {
             res = -errno;

Places

File pacemaker-libcrmcommon-handle-compression-failures-properly.patch of Package pacemaker.10804

Places