File bsc-1203931-04_drbd-fix-VerifyT-being-stuck-whe... of Package drbd

Overview Repositories Revisions Requests Users Attributes Meta

File bsc-1203931-04_drbd-fix-VerifyT-being-stuck-when-using-verify-with-.patch of Package drbd

From 542b176645bae06f9dc9a4e6c7d449fc4fbd01a2 Mon Sep 17 00:00:00 2001
From: Lars Ellenberg <lars.ellenberg@linbit.com>
Date: Fri, 22 Mar 2019 14:36:38 +0100
Subject: [PATCH] drbd: fix VerifyT being "stuck" when using verify with stop
 sector

If we start an online-verify with a stop sector, or adjust the stop
sector during a running online verify, only the L_VERIFY_S side
will know about it. The L_VERIFY_T side is notified via state change
in receive_state(), but because a year old merge mishap, it was testing
on C_CONNECTED instead L_ESTABLISHED, and ignored this notification.

Only shows that verify with "[start, stop]" sector intervals is not
often used, or it would not have gone unnoticed for so long.
---
 drbd/drbd_receiver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drbd/drbd_receiver.c b/drbd/drbd_receiver.c
index 877dd01dcb56..ccbaad9f55a9 100644
--- a/drbd/drbd_receiver.c
+++ b/drbd/drbd_receiver.c
@@ -6718,7 +6718,7 @@ static int receive_state(struct drbd_connection *connection, struct packet_info
 
 	/* explicit verify finished notification, stop sector reached. */
 	if (old_peer_state.conn == L_VERIFY_T && old_peer_state.disk == D_UP_TO_DATE &&
-	    peer_state.conn == C_CONNECTED && peer_disk_state == D_UP_TO_DATE) {
+	    peer_state.conn == L_ESTABLISHED && peer_disk_state == D_UP_TO_DATE) {
 		ov_out_of_sync_print(peer_device);
 		drbd_resync_finished(peer_device, D_MASK);
 		peer_device->last_repl_state = peer_state.conn;
-- 
2.26.2

Places

File bsc-1203931-04_drbd-fix-VerifyT-being-stuck-when-using-verify-with-.patch of Package drbd

Places