File 0001-misc-fix-invalid-character-recongition-in-... of Package grub2

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-misc-fix-invalid-character-recongition-in-strto-l.patch of Package grub2 (Revision e0d1ed7d3136d3b3d9fa39ae7572fe6f)

Currently displaying revision e0d1ed7d3136d3b3d9fa39ae7572fe6f , Show latest

From 0155e49166494624e9fb6ef113ed2c16d4accbb3 Mon Sep 17 00:00:00 2001
From: Michael Chang <mchang@suse.com>
Date: Fri, 29 Jul 2016 17:41:27 +0800
Subject: [PATCH 1/8] misc: fix invalid character recongition in strto*l

From: Aaron Miller <aaronmiller@fb.com>

Would previously allow digits larger than the base and didn't check that
subtracting the difference from 0-9 to lowercase letters for characters
larger than 9 didn't result in a value lower than 9, which allowed the
parses: ` = 9, _ = 8, ^ = 7, ] = 6, \ = 5, and [ = 4
---
 grub-core/kern/misc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index d1a54df..3a14d67 100644
--- a/grub-core/kern/misc.c
+++ b/grub-core/kern/misc.c
@@ -394,9 +394,13 @@ grub_strtoull (const char *str, char **end, int base)
       if (digit > 9)
 	{
 	  digit += '0' - 'a' + 10;
-	  if (digit >= (unsigned long) base)
+	  /* digit <= 9 check is needed to keep chars larger than
+	     '9' but less than 'a' from being read as numbers */
+	  if (digit >= (unsigned long) base || digit <= 9)
 	    break;
 	}
+      if (digit >= (unsigned long) base)
+	break;
 
       found = 1;
 
-- 
2.6.6

Places

File 0001-misc-fix-invalid-character-recongition-in-strto-l.patch of Package grub2 (Revision e0d1ed7d3136d3b3d9fa39ae7572fe6f)

Places