File 0025-Fixed-memory-leaks-in-new_xml_plist-and-pa... of Package libplist.4095

Overview Repositories Revisions Requests Users Attributes Meta

File 0025-Fixed-memory-leaks-in-new_xml_plist-and-parse_real_node.patch of Package libplist.4095

From bc147d80b5a608b8a0478041e5198093ecd767b8 Mon Sep 17 00:00:00 2001
From: Aaron Burghardt <aburgh@mac.com>
Date: Sun, 24 Aug 2014 21:11:36 -0400
Subject: [PATCH] Fixed memory leaks in new_xml_plist() and parse_real_node().

---
 src/bplist.c | 1 +
 src/xplist.c | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/bplist.c b/src/bplist.c
index 5789f26..91d5578 100644
--- a/src/bplist.c
+++ b/src/bplist.c
@@ -251,6 +251,7 @@ static plist_t parse_real_node(char *bnode, uint8_t size)
         data->realval = *(double *) buf;
         break;
     default:
+        free(buf);
         free(data);
         return NULL;
     }
diff --git a/src/xplist.c b/src/xplist.c
index 96539a6..a889cb5 100644
--- a/src/xplist.c
+++ b/src/xplist.c
@@ -120,9 +120,6 @@ static xmlDocPtr new_xml_plist(void)
     char *plist = strdup(plist_base);
     xmlDocPtr plist_xml = xmlParseMemory(plist, strlen(plist));
 
-    if (!plist_xml)
-        return NULL;
-
     free(plist);
 
     return plist_xml;

Places

File 0025-Fixed-memory-leaks-in-new_xml_plist-and-parse_real_node.patch of Package libplist.4095

Places