File 2816fe2e-qemu-fix-NULL-ptr-deref.patch of Package libvirt

Overview Repositories Revisions Requests Users Attributes Meta

File 2816fe2e-qemu-fix-NULL-ptr-deref.patch of Package libvirt

commit 2816fe2e846ab3bd2bfbef123c426a17f1e1df98
Author: Erik Skultety <eskultet@redhat.com>
Date:   Mon Nov 18 13:46:14 2019 +0100

qemu: Fix NULL ptr dereference caused by qemuDomainDefFormatBufInternal
    
    qemuDomainDefFormatBufInternal function wasn't testing whether the CPU
    was actually defined in the XML and saving such a domain resulted in the
    following backtrace:
    
    0 in qemuDomainMakeCPUMigratable (cpu=0x0)
    1 in qemuDomainDefFormatBufInternal()
    2 in qemuDomainDefFormatXMLInternal()
    3 in qemuDomainDefFormatLive()
    4 in qemuDomainSaveInternal()
    5 in qemuDomainSaveFlags()
    6 in qemuDomainSave()
    7 in virDomainSave()
    
    Signed-off-by: Erik Skultety <eskultet@redhat.com>
    Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Index: libvirt-5.1.0/src/qemu/qemu_domain.c
===================================================================
--- libvirt-5.1.0.orig/src/qemu/qemu_domain.c
+++ libvirt-5.1.0/src/qemu/qemu_domain.c
@@ -7932,7 +7932,7 @@ qemuDomainDefFormatBufInternal(virQEMUDr
                 goto cleanup;
         }
 
-        if (qemuDomainMakeCPUMigratable(def->cpu) < 0)
+        if (def->cpu && qemuDomainMakeCPUMigratable(def->cpu) < 0)
             goto cleanup;
     }

Places

File 2816fe2e-qemu-fix-NULL-ptr-deref.patch of Package libvirt

Places