File dbc04114-cpu_x86-Require-cpuid-within-feature-i... of Package libvirt

Overview Repositories Revisions Requests Users Attributes Meta

File dbc04114-cpu_x86-Require-cpuid-within-feature-in-CPU-map.patch of Package libvirt

commit dbc04114f3d14b53c999bd89db51276358b1aba3
Author: Jiri Denemark <jdenemar@redhat.com>
Date:   Wed Mar 13 10:23:01 2019 +0100

cpu_x86: Require <cpuid> within <feature> in CPU map
    
    A feature with no cpuid element is invalid and it should not be silently
    treated as a feature with all CPUID bits set to zero.
    
    Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
    Reviewed-by: Ján Tomko <jtomko@redhat.com>

Index: libvirt-5.1.0/src/cpu/cpu_x86.c
===================================================================
--- libvirt-5.1.0.orig/src/cpu/cpu_x86.c
+++ libvirt-5.1.0/src/cpu/cpu_x86.c
@@ -924,6 +924,13 @@ x86FeatureParse(xmlXPathContextPtr ctxt,
     if (n < 0)
         goto cleanup;
 
+    if (n == 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("Missing cpuid for feature %s"),
+                       feature->name);
+        goto cleanup;
+    }
+
     for (i = 0; i < n; i++) {
         ctxt->node = nodes[i];
         if (x86ParseCPUID(ctxt, &cpuid) < 0) {

Places

File dbc04114-cpu_x86-Require-cpuid-within-feature-in-CPU-map.patch of Package libvirt

Places