Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-12-SP5:Update
llvm.7809
backport-llvm-r236526
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File backport-llvm-r236526 of Package llvm.7809
------------------------------------------------------------------------ r236526 | uweigand | 2015-05-05 21:30:05 +0200 (Tue, 05 May 2015) | 11 lines [SystemZ] Mark v1i128 and v1f128 as unsupported The ABI specifies that <1 x i128> and <1 x fp128> are supposed to be passed in vector registers. We do not yet support those types, and some infrastructure is missing before we can do so. In order to prevent accidentally generating code violating the ABI, this patch adds checks to detect those types and error out if user code attempts to use them. ------------------------------------------------------------------------ Index: lib/Target/SystemZ/SystemZISelLowering.cpp =================================================================== --- lib/Target/SystemZ/SystemZISelLowering.cpp.orig +++ lib/Target/SystemZ/SystemZISelLowering.cpp @@ -782,6 +782,24 @@ bool SystemZTargetLowering::mayBeEmitted return true; } +// We do not yet support 128-bit single-element vector types. If the user +// attempts to use such types as function argument or return type, prefer +// to error out instead of emitting code violating the ABI. +static void VerifyVectorType(MVT VT, EVT ArgVT) { + if (ArgVT.isVector() && !VT.isVector()) + report_fatal_error("Unsupported vector argument or return type"); +} + +static void VerifyVectorTypes(const SmallVectorImpl<ISD::InputArg> &Ins) { + for (unsigned i = 0; i < Ins.size(); ++i) + VerifyVectorType(Ins[i].VT, Ins[i].ArgVT); +} + +static void VerifyVectorTypes(const SmallVectorImpl<ISD::OutputArg> &Outs) { + for (unsigned i = 0; i < Outs.size(); ++i) + VerifyVectorType(Outs[i].VT, Outs[i].ArgVT); +} + // Value is a value that has been passed to us in the location described by VA // (and so has type VA.getLocVT()). Convert Value to VA.getValVT(), chaining // any loads onto Chain. @@ -855,6 +873,10 @@ LowerFormalArguments(SDValue Chain, Call const SystemZFrameLowering *TFL = static_cast<const SystemZFrameLowering *>(TM.getFrameLowering()); + // Detect unsupported vector argument types. + if (Subtarget.hasVector()) + VerifyVectorTypes(Ins); + // Assign locations to all of the incoming arguments. SmallVector<CCValAssign, 16> ArgLocs; SystemZCCState CCInfo(CallConv, IsVarArg, MF, TM, @@ -1002,6 +1024,12 @@ SystemZTargetLowering::LowerCall(CallLow MachineFunction &MF = DAG.getMachineFunction(); EVT PtrVT = getPointerTy(); + // Detect unsupported vector argument and return types. + if (Subtarget.hasVector()) { + VerifyVectorTypes(Outs); + VerifyVectorTypes(Ins); + } + // Analyze the operands of the call, assigning locations to each operand. SmallVector<CCValAssign, 16> ArgLocs; SystemZCCState ArgCCInfo(CallConv, IsVarArg, MF, TM, @@ -1157,6 +1185,10 @@ SystemZTargetLowering::LowerReturn(SDVal SDLoc DL, SelectionDAG &DAG) const { MachineFunction &MF = DAG.getMachineFunction(); + // Detect unsupported vector return types. + if (Subtarget.hasVector()) + VerifyVectorTypes(Outs); + // Assign locations to each returned value. SmallVector<CCValAssign, 16> RetLocs; CCState RetCCInfo(CallConv, IsVarArg, MF, TM, RetLocs, *DAG.getContext()); Index: test/CodeGen/SystemZ/vec-args-error-03.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-03.ll @@ -0,0 +1,12 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +declare void @bar(<1 x i128>) + +define void @foo() { + call void @bar (<1 x i128> <i128 0>) + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-04.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-04.ll @@ -0,0 +1,12 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +declare <1 x i128> @bar() + +define void @foo() { + %res = call <1 x i128> @bar () + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-05.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-05.ll @@ -0,0 +1,9 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +define void @foo(<1 x fp128>) { + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-06.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-06.ll @@ -0,0 +1,9 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +define <1 x fp128> @foo() { + ret <1 x fp128><fp128 0xL00000000000000000000000000000000> +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-01.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-01.ll @@ -0,0 +1,9 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +define void @foo(<1 x i128>) { + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-07.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-07.ll @@ -0,0 +1,12 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +declare void @bar(<1 x fp128>) + +define void @foo() { + call void @bar (<1 x fp128> <fp128 0xL00000000000000000000000000000000>) + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-02.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-02.ll @@ -0,0 +1,9 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +define <1 x i128> @foo() { + ret <1 x i128><i128 0> +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type Index: test/CodeGen/SystemZ/vec-args-error-08.ll =================================================================== --- /dev/null +++ test/CodeGen/SystemZ/vec-args-error-08.ll @@ -0,0 +1,12 @@ +; Verify that we detect unsupported single-element vector types. + +; RUN: not llc < %s -mtriple=s390x-linux-gnu -mcpu=z13 2>&1 | FileCheck %s + +declare <1 x fp128> @bar() + +define void @foo() { + %res = call <1 x fp128> @bar () + ret void +} + +; CHECK: LLVM ERROR: Unsupported vector argument or return type
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor