File 0010-stt-Fix-return-code-during-xmit.patch of Package openvswitch-dpdk.10750

Overview Repositories Revisions Requests Users Attributes Meta

File 0010-stt-Fix-return-code-during-xmit.patch of Package openvswitch-dpdk.10750

From af0840c34fbb6fb43359803c30aafa1aec14d708 Mon Sep 17 00:00:00 2001
From: Aaron Conole <aconole@redhat.com>
Date: Thu, 24 Jan 2019 10:20:13 -0800
Subject: [PATCH 10/14] stt: Fix return code during xmit.

In the case of an error, return the error code as opposed to
NETDEV_TX_OK.

Caught by compiler warning:

/home/travis/build/ovsrobot/ovs/datapath/linux/stt.c: In function =E2=80=
=98ovs_stt_xmit=E2=80=99:
  /home/travis/build/ovsrobot/ovs/datapath/linux/stt.c:1005:6: warning: var=
iable =E2=80=98err=E2=80=99 set but not used [-Wunused-but-set-variable]
    int err;
        ^

Signed-off-by: Aaron Conole <aconole@redhat.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 datapath/linux/compat/stt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
index eb397e85b..af7464716 100644
--- a/datapath/linux/compat/stt.c
+++ b/datapath/linux/compat/stt.c
@@ -981,7 +981,7 @@ netdev_tx_t ovs_stt_xmit(struct sk_buff *skb)
 error:
 	kfree_skb(skb);
 	dev->stats.tx_errors++;
-	return NETDEV_TX_OK;
+	return err;
 }
 EXPORT_SYMBOL(ovs_stt_xmit);
 
-- 
2.21.0

Places

File 0010-stt-Fix-return-code-during-xmit.patch of Package openvswitch-dpdk.10750

Places