File b347c0c2-CVE-2015-0236.patch of Package libvirt

Overview Repositories Revisions Requests Users Attributes Meta

File b347c0c2-CVE-2015-0236.patch of Package libvirt (Revision 49c4f6bd23e58ed75633aab87164aea2)

Currently displaying revision 49c4f6bd23e58ed75633aab87164aea2 , Show latest

commit b347c0c2a321ec5c20aae214927949832a288c5a
Author: Peter Krempa <pkrempa@redhat.com>
Date:   Tue Jan 20 17:01:01 2015 +0100

CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots
    
    The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the
    appropriate permission for it. Found via code inspection while fixing
    permissions for save images.

Index: libvirt-1.2.5/src/qemu/qemu_driver.c
===================================================================
--- libvirt-1.2.5.orig/src/qemu/qemu_driver.c
+++ libvirt-1.2.5/src/qemu/qemu_driver.c
@@ -13912,7 +13912,7 @@ static char *qemuDomainSnapshotGetXMLDes
     if (!(vm = qemuDomObjFromSnapshot(snapshot)))
         goto cleanup;
 
-    if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def) < 0)
+    if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def, flags) < 0)
         goto cleanup;
 
     if (!(snap = qemuSnapObjFromSnapshot(vm, snapshot)))
Index: libvirt-1.2.5/src/remote/remote_protocol.x
===================================================================
--- libvirt-1.2.5.orig/src/remote/remote_protocol.x
+++ libvirt-1.2.5/src/remote/remote_protocol.x
@@ -4337,6 +4337,7 @@ enum remote_procedure {
      * @generate: both
      * @priority: high
      * @acl: domain:read
+     * @acl: domain:read_secure:VIR_DOMAIN_XML_SECURE
      */
     REMOTE_PROC_DOMAIN_SNAPSHOT_GET_XML_DESC = 186,

Places

File b347c0c2-CVE-2015-0236.patch of Package libvirt (Revision 49c4f6bd23e58ed75633aab87164aea2)

Places