File 0001-ndisc-don-t-artificially-extend-the-lifeti... of Package NetworkManager

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-ndisc-don-t-artificially-extend-the-lifetime-of-DNSS.patch of Package NetworkManager

From 68528f7af564762042afd47ef03fde7a0ab2a8b4 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Wed, 13 Jan 2021 17:49:49 +0100
Subject: [PATCH] ndisc: don't artificially extend the lifetime of DNSSL/RDNSS
 options

RFCs actually expect to honor the lifetime. See for example [1].

This is just not right, and totally arbitrary. It was added
when our libndp based implementation was added, but unclear
why this was done (beyond the code comment).

[1] page 204, v6LC.2.2.25: Processing Router Advertisement DNS (Host
    only) at https://ipv6ready.org/docs/Core_Conformance_5_0_0.pdf
---
 src/ndisc/nm-lndp-ndisc.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/src/ndisc/nm-lndp-ndisc.c b/src/ndisc/nm-lndp-ndisc.c
index 34d701aa01..2117190584 100644
--- a/src/ndisc/nm-lndp-ndisc.c
+++ b/src/ndisc/nm-lndp-ndisc.c
@@ -241,13 +241,6 @@ receive_ra(struct ndp *ndp, struct ndp_msg *msg, gpointer user_data)
 				.lifetime = ndp_msg_opt_rdnss_lifetime (msg, offset),
 			};
 
-			/* Pad the lifetime somewhat to give a bit of slack in cases
-			 * where one RA gets lost or something (which can happen on unreliable
-			 * links like Wi-Fi where certain types of frames are not retransmitted).
-			 * Note that 0 has special meaning and is therefore not adjusted.
-			 */
-			if (dns_server.lifetime && dns_server.lifetime < 7200)
-				dns_server.lifetime = 7200;
 			if (nm_ndisc_add_dns_server (ndisc, &dns_server))
 				changed |= NM_NDISC_CONFIG_DNS_SERVERS;
 		}
@@ -263,13 +256,6 @@ receive_ra(struct ndp *ndp, struct ndp_msg *msg, gpointer user_data)
 				.lifetime = ndp_msg_opt_dnssl_lifetime (msg, offset),
 			};
 
-			/* Pad the lifetime somewhat to give a bit of slack in cases
-			 * where one RA gets lost or something (which can happen on unreliable
-			 * links like Wi-Fi where certain types of frames are not retransmitted).
-			 * Note that 0 has special meaning and is therefore not adjusted.
-			 */
-			if (dns_domain.lifetime && dns_domain.lifetime < 7200)
-				dns_domain.lifetime = 7200;
 			if (nm_ndisc_add_dns_domain (ndisc, &dns_domain))
 				changed |= NM_NDISC_CONFIG_DNS_DOMAINS;
 		}
-- 
2.26.2

Places

File 0001-ndisc-don-t-artificially-extend-the-lifetime-of-DNSS.patch of Package NetworkManager

Places