File ndctl-Use-the-same-align-value-as-original-name... of Package ndctl

Overview Repositories Revisions Requests Users Attributes Meta

File ndctl-Use-the-same-align-value-as-original-namespace-on-reconfigure.patch of Package ndctl (Revision f98892f6338619c9f11e87cb8bfbc1ec)

Currently displaying revision f98892f6338619c9f11e87cb8bfbc1ec , Show latest

From patchwork Wed Aug  7 04:44:16 2019
X-Patchwork-Submitter: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
X-Patchwork-Id: 11080973
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: dan.j.williams@intel.com
Subject: [PATCH] ndctl: Use the same align value as original namespace on
 reconfigure
Date: Wed,  7 Aug 2019 10:14:16 +0530
Message-Id: <20190807044416.30799-1-aneesh.kumar@linux.ibm.com>

When using reconfigure command to add a `name` to the namespace we end
up updating the align attribute. Avoid this by using the value from
the original namespace. Do this only if we are keeping the namespace mode
same.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
 ndctl/namespace.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/ndctl/namespace.c b/ndctl/namespace.c
index 1f212a2b3a9b..24e51bb35ae1 100644
--- a/ndctl/namespace.c
+++ b/ndctl/namespace.c
@@ -596,6 +596,22 @@ static int validate_namespace_options(struct ndctl_region *region,
 			return -ENXIO;
 		}
 	} else {
+
+		/*
+		 * If we are tryint to reconfigure with the same namespace mode
+		 * Use the align details from the origin namespace. Otherwise
+		 * pick the align details from seed namespace
+		 */
+		if (ndns && p->mode == ndctl_namespace_get_mode(ndns)) {
+			struct ndctl_pfn *ns_pfn = ndctl_namespace_get_pfn(ndns);
+			struct ndctl_dax *ns_dax = ndctl_namespace_get_dax(ndns);
+			if (ns_pfn)
+				p->align = ndctl_pfn_get_align(ns_pfn);
+			else if (ns_dax)
+				p->align = ndctl_dax_get_align(ns_dax);
+			else
+				p->align = sysconf(_SC_PAGE_SIZE);
+		} else
 		/*
 		 * Use the seed namespace alignment as the default if we need
 		 * one. If we don't then use PAGE_SIZE so the size_align

Places

File ndctl-Use-the-same-align-value-as-original-namespace-on-reconfigure.patch of Package ndctl (Revision f98892f6338619c9f11e87cb8bfbc1ec)

Places