File CVE-2021-28957-prevent-formaction.patch of Package python-lxml

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2021-28957-prevent-formaction.patch of Package python-lxml

From 10ec1b4e9f93713513a3264ed6158af22492f270 Mon Sep 17 00:00:00 2001
From: Kevin Chung <kchung@nyu.edu>
Date: Sat, 20 Mar 2021 02:49:25 -0400
Subject: [PATCH 1/2] Add formaction attribute to defs.link_attrs

---
 src/lxml/html/defs.py | 2 ++
 1 file changed, 2 insertions(+)

Index: lxml-4.0.0/src/lxml/html/defs.py
===================================================================
--- lxml-4.0.0.orig/src/lxml/html/defs.py
+++ lxml-4.0.0/src/lxml/html/defs.py
@@ -21,6 +21,8 @@ link_attrs = frozenset([
     'usemap',
     # Not standard:
     'dynsrc', 'lowsrc',
+    # HTML5 formaction
+    'formaction'
     ])
 
 # Not in the HTML 4 spec:
Index: lxml-4.0.0/src/lxml/html/tests/test_clean.py
===================================================================
--- lxml-4.0.0.orig/src/lxml/html/tests/test_clean.py
+++ lxml-4.0.0/src/lxml/html/tests/test_clean.py
@@ -79,6 +79,21 @@ class CleanerTest(unittest.TestCase):
             b'<noscript><style>/* deleted */</style></noscript>',
             lxml.html.tostring(clean_html(s)))
 
+    def test_formaction_attribute_in_button_input(self):
+        # The formaction attribute overrides the form's action and should be
+        # treated as a malicious link attribute
+        html = ('<form id="test"><input type="submit" formaction="javascript:alert(1)"></form>'
+        '<button form="test" formaction="javascript:alert(1)">X</button>')
+        expected = ('<div><form id="test"><input type="submit" formaction=""></form>'
+        '<button form="test" formaction="">X</button></div>')
+        cleaner = Cleaner(
+            forms=False,
+            safe_attrs_only=False,
+        )
+        self.assertEqual(
+            expected,
+            cleaner.clean_html(html))
+
 
 def test_suite():
     suite = unittest.TestSuite()

Places

File CVE-2021-28957-prevent-formaction.patch of Package python-lxml

Places