File 5d43253c-x86-ucode-always-collect_cpu_info-at-b... of Package xen.16553

Overview Repositories Revisions Requests Users Attributes Meta

File 5d43253c-x86-ucode-always-collect_cpu_info-at-boot.patch of Package xen.16553

# Commit 2bb2c55cf870e78bc7f514784b2cd8c947d8729c
# Date 2019-08-01 18:45:32 +0100
# Author Sergey Dyasli <sergey.dyasli@citrix.com>
# Committer Andrew Cooper <andrew.cooper3@citrix.com>
x86/microcode: always collect_cpu_info() during boot

Currently cpu_sig struct is not updated during boot if no microcode blob
is specified by "ucode=[<interger>| scan]".

It will result in cpu_sig.rev being 0 which affects APIC's
check_deadline_errata() and retpoline_safe() functions.

Fix this by getting ucode revision early during boot and SMP bring up.
While at it, protect early_microcode_update_cpu() for cases when
microcode_ops is NULL.

Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
Signed-off-by: Chao Gao <chao.gao@intel.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

--- a/xen/arch/x86/microcode.c
+++ b/xen/arch/x86/microcode.c
@@ -387,10 +387,15 @@ static struct notifier_block microcode_p
 
 int __init early_microcode_update_cpu(bool start_update)
 {
+    unsigned int cpu = smp_processor_id();
+    struct ucode_cpu_info *uci = &per_cpu(ucode_cpu_info, cpu);
     int rc = 0;
     void *data = NULL;
     size_t len;
 
+    if ( !microcode_ops )
+        return -ENOSYS;
+
     if ( ucode_blob.size )
     {
         len = ucode_blob.size;
@@ -401,6 +406,9 @@ int __init early_microcode_update_cpu(bo
         len = ucode_mod.mod_end;
         data = ucode_mod_map(&ucode_mod);
     }
+
+    microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig);
+
     if ( data )
     {
         if ( start_update && microcode_ops->start_update )
@@ -417,6 +425,8 @@ int __init early_microcode_update_cpu(bo
 
 int __init early_microcode_init(void)
 {
+    unsigned int cpu = smp_processor_id();
+    struct ucode_cpu_info *uci = &per_cpu(ucode_cpu_info, cpu);
     int rc;
 
     rc = microcode_init_intel();
@@ -429,6 +439,8 @@ int __init early_microcode_init(void)
 
     if ( microcode_ops )
     {
+        microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig);
+
         if ( ucode_mod.mod_end || ucode_blob.size )
             rc = early_microcode_update_cpu(true);

Places

File 5d43253c-x86-ucode-always-collect_cpu_info-at-boot.patch of Package xen.16553

Places