File 0001-client-plasmashell-add-fallback-for-applet... of Package kwayland

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-client-plasmashell-add-fallback-for-applet-popups.patch of Package kwayland (Revision db59e2362b1aca2b1abbe2dd296e7d17)

Currently displaying revision db59e2362b1aca2b1abbe2dd296e7d17 , Show latest

From d02188ad1f6222215adcf842f4c9806ba9e62ccb Mon Sep 17 00:00:00 2001
From: Xaver Hugl <xaver.hugl@gmail.com>
Date: Sat, 17 Sep 2022 01:18:28 +0200
Subject: [PATCH] client/plasmashell: add fallback for applet popups

When the compositor doesn't support applet popups, the current code sends an
invalid surface role. This causes KWin to fall back to the "normal" surface role
and do normal window placement on it.

CCBUG: 459188
---
 src/client/plasmashell.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/client/plasmashell.cpp b/src/client/plasmashell.cpp
index dc613cb5..93bc31c7 100644
--- a/src/client/plasmashell.cpp
+++ b/src/client/plasmashell.cpp
@@ -276,7 +276,14 @@ void PlasmaShellSurface::setRole(PlasmaShellSurface::Role role)
         }
         break;
     case Role::AppletPopup:
-        wlRole = ORG_KDE_PLASMA_SURFACE_ROLE_APPLETPOPUP;
+        // ORG_KDE_PLASMA_SURFACE_ROLE_APPLETPOPUP_SINCE_VERSION is not used for this check
+        // because it wrongly is 7 with old plasma wayland protocols
+        if (wl_proxy_get_version(d->surface) < 8) {
+            // dock is what applet popups were before
+            wlRole = ORG_KDE_PLASMA_SURFACE_ROLE_PANEL;
+        } else {
+            wlRole = ORG_KDE_PLASMA_SURFACE_ROLE_APPLETPOPUP;
+        }
         break;
     default:
         Q_UNREACHABLE();
-- 
2.37.3

Places

File 0001-client-plasmashell-add-fallback-for-applet-popups.patch of Package kwayland (Revision db59e2362b1aca2b1abbe2dd296e7d17)

Places