File avoid_sys_modules_hackery.patch of Package python-traits

Overview Repositories Revisions Requests Users Attributes Meta

File avoid_sys_modules_hackery.patch of Package python-traits (Revision a646357e9b2f7b9aa69283ea50485421)

Currently displaying revision a646357e9b2f7b9aa69283ea50485421 , Show latest

From 652ca3847a8e4b53cca195f8574135ff6080902b Mon Sep 17 00:00:00 2001
From: Mark Dickinson <mdickinson@enthought.com>
Date: Wed, 30 Jan 2019 14:44:11 +0000
Subject: [PATCH] Avoid sys.modules hackery in a test.

---
 traits/tests/test_trait_types.py | 54 +++++++++++++++++++++-----------
 1 file changed, 35 insertions(+), 19 deletions(-)

diff --git a/traits/tests/test_trait_types.py b/traits/tests/test_trait_types.py
index e58e55fb..34138c7b 100644
--- a/traits/tests/test_trait_types.py
+++ b/traits/tests/test_trait_types.py
@@ -18,7 +18,20 @@
 """ Unit test case for testing trait types created by subclassing TraitType.
 """
 
-from traits.testing.unittest_tools import unittest
+import os
+import sys
+import tempfile
+import textwrap
+import shutil
+import subprocess
+import unittest
+
+try:
+    import numpy  # noqa F401
+except ImportError:
+    numpy_available = False
+else:
+    numpy_available = True
 
 from traits.api import Float, TraitType
 
@@ -35,28 +48,31 @@ def get(self, obj, name):
         LazyProperty().as_ctrait()
         self.assertFalse(Float().transient)
 
+    @unittest.skipUnless(numpy_available, "test requires NumPy")
     def test_numpy_validators_loaded_if_numpy_present(self):
-        # If 'numpy' is available, the numpy validators should be loaded.
-
-        # Make sure that numpy is present on this machine.
-        try:
+        # If 'numpy' is available, the numpy validators should be loaded,
+        # even if numpy is imported after traits.
+        test_script = textwrap.dedent("""
+            from traits.trait_types import float_fast_validate
             import numpy
-        except ImportError:
-            self.skipTest("numpy library not found.")
 
-        # Remove numpy from the list of imported modules.
-        import sys
-
-        del sys.modules["numpy"]
-        for k in list(sys.modules):
-            if k.startswith("numpy."):
-                del sys.modules[k]
-
-        # Check that the validators contain the numpy types.
-        from traits.trait_types import float_fast_validate
-        import numpy
+            if numpy.floating in float_fast_validate:
+                print("Success")
+            else:
+                print("Failure")
+        """)
+        this_python = sys.executable
+        tmpdir = tempfile.mkdtemp()
+        try:
+            tmpfile = os.path.join(tmpdir, "test_script.py")
+            with open(tmpfile, "w") as f:
+                f.write(test_script)
+            cmd = [this_python, tmpfile]
+            output = subprocess.check_output(cmd).decode("utf-8")
+        finally:
+            shutil.rmtree(tmpdir)
 
-        self.assertIn(numpy.floating, float_fast_validate)
+        self.assertEqual(output.strip(), "Success")
 
 
 # Run the unit tests (if invoked from the command line):

Places

File avoid_sys_modules_hackery.patch of Package python-traits (Revision a646357e9b2f7b9aa69283ea50485421)

Places